Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 334303003: Only assign enhanced bookmarks metainfo ID if not already present (Closed)

Created:
6 years, 6 months ago by Mike Wittman
Modified:
6 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Only assign enhanced bookmarks metainfo ID if not already present Fixes the case where this code path is executed via sync and an ID has already been assigned. BUG=383557 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike Wittman
6 years, 6 months ago (2014-06-18 20:27:25 UTC) #1
Yoyo Zhou
LGTM (no tests?)
6 years, 6 months ago (2014-06-18 20:39:20 UTC) #2
Mike Wittman
On 2014/06/18 20:39:20, Yoyo Zhou wrote: > LGTM (no tests?) I haven't found an easy ...
6 years, 6 months ago (2014-06-18 21:18:20 UTC) #3
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 6 months ago (2014-06-18 21:18:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/334303003/1
6 years, 6 months ago (2014-06-18 21:20:48 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 06:40:31 UTC) #6
Message was sent while issue was closed.
Change committed as 278286

Powered by Google App Engine
This is Rietveld 408576698