Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 334303003: Only assign enhanced bookmarks metainfo ID if not already present (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
index 06b023eef882f7838902e2bace1d08264c15a1d3..ce3835296c163d465699b7c6811576d70e4b28ef 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
@@ -355,7 +355,9 @@ void BookmarkEventRouter::OnWillAddBookmarkNode(BookmarkModel* model,
if (IsEnhancedBookmarksExtensionActive(Profile::FromBrowserContext(
browser_context_))) {
static const char key[] = "stars.id";
- node->SetMetaInfo(key, GenerateEnhancedBookmarksID(node->is_folder()));
+ std::string value;
+ if (!node->GetMetaInfo(key, &value))
+ node->SetMetaInfo(key, GenerateEnhancedBookmarksID(node->is_folder()));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698