Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334263022: Include wtf/RefCounted.h less often in modules/ (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, ericu+idb_chromium.org, tzik, philipj_slow, alecflett, eric.carlson_apple.com, Raymond Toy, nhiroki, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, dgrogan, timvolodine, cmumford, jsbell+idb_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Include wtf/RefCounted.h less often in modules/ With Oilpan enabled by default, tidy up #include use somewhat. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -64 lines) Patch
M Source/modules/battery/BatteryStatus.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/AesKeyAlgorithm.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/Crypto.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/crypto/CryptoKey.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/KeyAlgorithm.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/SubtleCrypto.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/gamepad/Gamepad.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/GamepadButton.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/GamepadList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/WebKitGamepad.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/WebKitGamepadList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBAny.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBKeyRange.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IndexedDBClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/modules/mediasource/VideoPlaybackQuality.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCStatsRequestImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/performance/SharedWorkerPerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/WorkerPerformance.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/StorageErrorCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/StorageQuotaClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioBasicProcessorNode.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/webaudio/AudioParamTimeline.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/webaudio/PeriodicWave.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseResource.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLResultSetRowList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/websockets/WebSocket.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/WebSocketChannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-26 12:34:27 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-26 12:36:39 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-26 14:34:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/334263022/1
6 years, 6 months ago (2014-06-26 14:36:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-26 15:42:24 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 18:40:23 UTC) #6
Message was sent while issue was closed. 
Change committed as 177014

Powered by Google App Engine
This is Rietveld 408576698