Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 334263007: Remove unneeded checks in RenderTreeBuilder (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unneeded checks in RenderTreeBuilder Remove unneeded checks in RenderTreeBuilder, the same check is done in RenderTreeBuilder::shouldCreateRenderer. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176426

Patch Set 1 #

Patch Set 2 : Address #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M Source/core/dom/RenderTreeBuilder.cpp View 1 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rwlbuis
PTAL
6 years, 6 months ago (2014-06-16 22:43:23 UTC) #1
esprehn
I'd rather we went the other way and removed the code duplication that checks m_renderingParent ...
6 years, 6 months ago (2014-06-17 00:23:34 UTC) #2
rwlbuis
On 2014/06/17 00:23:34, esprehn wrote: > I'd rather we went the other way and removed ...
6 years, 6 months ago (2014-06-17 15:15:38 UTC) #3
esprehn
lgtm, but please update the patch title and description before landing.
6 years, 6 months ago (2014-06-18 06:15:09 UTC) #4
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 6 months ago (2014-06-18 13:01:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/334263007/20001
6 years, 6 months ago (2014-06-18 13:01:42 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 15:05:37 UTC) #7
Message was sent while issue was closed.
Change committed as 176426

Powered by Google App Engine
This is Rietveld 408576698