Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: Source/core/dom/RenderTreeBuilder.cpp

Issue 334263007: Remove unneeded checks in RenderTreeBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address #2 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/RenderTreeBuilder.cpp
diff --git a/Source/core/dom/RenderTreeBuilder.cpp b/Source/core/dom/RenderTreeBuilder.cpp
index 2454d57bb746e5defc65823c1392b4859944209b..974a1fa5c53f6322ffb0105d4af4db412e952fc8 100644
--- a/Source/core/dom/RenderTreeBuilder.cpp
+++ b/Source/core/dom/RenderTreeBuilder.cpp
@@ -104,15 +104,10 @@ void RenderTreeBuilder::createRendererForElementIfNeeded()
{
ASSERT(!m_node->renderer());
- // If we're out of composition then we can't render since there's no parent to inherit from.
- if (!m_renderingParent)
- return;
-
- Element* element = toElement(m_node);
-
if (!shouldCreateRenderer())
return;
+ Element* element = toElement(m_node);
RenderStyle& style = this->style();
if (!element->rendererIsNeeded(style))
@@ -151,10 +146,6 @@ void RenderTreeBuilder::createRendererForTextIfNeeded()
{
ASSERT(!m_node->renderer());
- // If we're out of composition then we can't render since there's no parent to inherit from.
- if (!m_renderingParent)
- return;
-
if (!shouldCreateRenderer())
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698