Fix multi-finger click no entry bug in TouchExplorationController

Fix multi-finger click no entry bug in TouchExplorationController

Fixes a bug where user starts a right click through double tap long press or split tap long press, and places down more fingers, resulting in a no-entry sign over a grey box appearing on the screen that the user cannot leave by clicking.

This was fixed by making sure the release of the long press has the same touch id as the press, where before it was the id final finger to be released.

BUG=385302
TEST=TouchExplorationTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278310

[evy, 2014-06-16 23:30:18]

Fixed the bug! 
The issue was related to something in DoubleTapPress, where the release was tied
with the id of the last finger released, not the finger that made the initial
press. 

I made a test for this too, but the test is reliant on split tap, so we'll have
to wait to push commit split tap before we can commit this bug fix - though I
can make a test that uses double tap too if you'd rather push this sooner.

[dmazzoni, 2014-06-17 15:43:52]

Looks great! We can commit this after split tap.

[dmazzoni, 2014-06-18 16:01:44]

Please rebase this change, I think it will be ready to go!

[evy, 2014-06-18 17:59:26]

Rebased - should be ready to commit once the tests go through.

[dmazzoni, 2014-06-18 18:06:15]

Please update the change description to match the style James Cook suggested.
Note that the subject and the first line of the description should be the same.

His suggestion was:

Add new_feature to existing_subsystem

One or two sentence description of what the feature does and/or why this change
was made.

* Specific thing changed 1
* Specific thing changed 2

BUG=12345
TEST=ui_unittests TestSuite.* (or TestSuite.MyNewTest)

In this particular case, maybe something like:

Subject: Fix multi-finger click no entry bug

Fix multi-finger click no entry bug

Fixes a bug where (... happens) by making sure that
the release event from a ... has the same touch id as
...

BUG=12345

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
File ui/chromeos/touch_exploration_controller.h (right):

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller.h:67: // If the user enters touch
exploration mode, they can click without lifting
Oops, looks like this got added twice in the rebase.

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
File ui/chromeos/touch_exploration_controller_unittest.cc (right):

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller_unittest.cc:924: // Placing a third
finger on the screen should be discarded and not effect
nit: effect -> affect

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller_unittest.cc:953: }
nit: should not be indented - please fix other trailing brace, above.

Add a blank line after this before the final brace that closes the namespace.

[evy, 2014-06-18 18:20:43]

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
File ui/chromeos/touch_exploration_controller.h (right):

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller.h:67: // If the user enters touch
exploration mode, they can click without lifting
On 2014/06/18 18:06:14, dmazzoni wrote:
> Oops, looks like this got added twice in the rebase.

Done.

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
File ui/chromeos/touch_exploration_controller_unittest.cc (right):

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller_unittest.cc:924: // Placing a third
finger on the screen should be discarded and not effect
On 2014/06/18 18:06:14, dmazzoni wrote:
> nit: effect -> affect

Done.

https://codereview.chromium.org/334223007/diff/40001/ui/chromeos/touch_explor...
ui/chromeos/touch_exploration_controller_unittest.cc:953: }
On 2014/06/18 18:06:14, dmazzoni wrote:
> nit: should not be indented - please fix other trailing brace, above.
> 
> Add a blank line after this before the final brace that closes the namespace.
> 

Done.

[dmazzoni, 2014-06-18 18:23:08]

lgtm

[commit-bot: I haz the power, 2014-06-18 18:24:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/evy@chromium.org/334223007/60001

[commit-bot: I haz the power, 2014-06-19 09:00:07]

Change committed as 278310