Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: ui/chromeos/touch_exploration_controller.h

Issue 334223007: Fix multi-finger click no entry bug in TouchExplorationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_tap
Patch Set: rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_ 5 #ifndef UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_
6 #define UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_ 6 #define UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_
7 7
8 #include "base/timer/timer.h" 8 #include "base/timer/timer.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "ui/chromeos/ui_chromeos_export.h" 10 #include "ui/chromeos/ui_chromeos_export.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 // If the user double-taps, the second tap is passed through, allowing the 57 // If the user double-taps, the second tap is passed through, allowing the
58 // user to click - however, the double-tap location is changed to the location 58 // user to click - however, the double-tap location is changed to the location
59 // of the last successful touch exploration - that allows the user to explore 59 // of the last successful touch exploration - that allows the user to explore
60 // anywhere on the screen, hear its description, then double-tap anywhere 60 // anywhere on the screen, hear its description, then double-tap anywhere
61 // to activate it. 61 // to activate it.
62 // 62 //
63 // If the user enters touch exploration mode, they can click without lifting 63 // If the user enters touch exploration mode, they can click without lifting
64 // their touch exploration finger by tapping anywhere else on the screen with 64 // their touch exploration finger by tapping anywhere else on the screen with
65 // a second finger, while the touch exploration finger is still pressed. 65 // a second finger, while the touch exploration finger is still pressed.
66 // 66 //
67 // If the user enters touch exploration mode, they can click without lifting
dmazzoni 2014/06/18 18:06:14 Oops, looks like this got added twice in the rebas
evy 2014/06/18 18:20:43 Done.
68 // their touch exploration finger by tapping anywhere else on the screen with
69 // a second finger, while the touch exploration finger is still pressed.
70 //
67 // If the user adds a second finger during the grace period, they enter 71 // If the user adds a second finger during the grace period, they enter
68 // passthrough mode. In this mode, the first finger is ignored but all 72 // passthrough mode. In this mode, the first finger is ignored but all
69 // additional touch events are mostly passed through unmodified. So a 73 // additional touch events are mostly passed through unmodified. So a
70 // two-finger scroll gets passed through as a one-finger scroll. However, 74 // two-finger scroll gets passed through as a one-finger scroll. However,
71 // once in passthrough mode, if one finger is released, the remaining fingers 75 // once in passthrough mode, if one finger is released, the remaining fingers
72 // continue to pass through events, allowing the user to start a scroll 76 // continue to pass through events, allowing the user to start a scroll
73 // with two fingers but finish it with one. Sometimes this requires rewriting 77 // with two fingers but finish it with one. Sometimes this requires rewriting
74 // the touch ids. 78 // the touch ids.
75 // 79 //
76 // Once either touch exploration or passthrough mode has been activated, 80 // Once either touch exploration or passthrough mode has been activated,
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 226
223 // A copy of the previous event passed. 227 // A copy of the previous event passed.
224 scoped_ptr<ui::TouchEvent> prev_event_; 228 scoped_ptr<ui::TouchEvent> prev_event_;
225 229
226 DISALLOW_COPY_AND_ASSIGN(TouchExplorationController); 230 DISALLOW_COPY_AND_ASSIGN(TouchExplorationController);
227 }; 231 };
228 232
229 } // namespace ui 233 } // namespace ui
230 234
231 #endif // UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_ 235 #endif // UI_CHROMEOS_TOUCH_EXPLORATION_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | ui/chromeos/touch_exploration_controller.cc » ('j') | ui/chromeos/touch_exploration_controller_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698