Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334223005: Qualify the generated includes in core (part 6) (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, shans, eae+blinkwatch, fs, kouhei+svg_chromium.org, rwlbuis, krit, Mike Lawther (Google), Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, Eric Willigers, kenneth.christiansen, Steve Block, rjwright, zoltan1, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, blink-reviews-events_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Qualify the generated includes in core (part 6) This CL takes care the page, plugins, rendering, and svg subdirs under core. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -226 lines) Patch
M Source/core/page/Chrome.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/FocusController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/TouchDisambiguation.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/plugins/PluginOcclusionSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDetailsMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFieldset.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderIFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMarquee.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProviderLinux.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/TextAutosizer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/style/KeyframeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleWillChangeData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGPathData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGResourcesCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAltGlyphDefElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphDefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAltGlyphItemElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateTransformElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedAngle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDefsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDescElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGDiscardElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDistantLightElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFloodElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncAElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncBElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncRElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFELightElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEOffsetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEPointLightElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFESpotLightElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFETileElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFitToViewBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceNameElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGeometryElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphRefElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphRefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGHKernElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLineElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLinearGradientElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMetadataElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGMissingGlyphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolygonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolylineElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRemoteFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSetElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGStopElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSwitchElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSymbolElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTSpanElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTextElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTitleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransformList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGURIReference.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGVKernElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGViewElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGZoomAndPan.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
c.shu
6 years, 6 months ago (2014-06-16 17:47:28 UTC) #1
rwlbuis
lgtm
6 years, 6 months ago (2014-06-16 20:15:41 UTC) #2
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-16 20:16:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/334223005/1
6 years, 6 months ago (2014-06-16 20:17:13 UTC) #4
commit-bot: I haz the power
Change committed as 176237
6 years, 6 months ago (2014-06-16 20:24:42 UTC) #5
haraken
6 years, 6 months ago (2014-06-16 23:07:06 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698