Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 334203002: chrome, extensions: Replaced GetScriptResourceName with GetScriptOrigin().ResourceName() (Closed)

Created:
6 years, 6 months ago by kozyatinskiy1
Modified:
6 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replaced deprecated v8::Message::GetScriptResourceName() with v8::Message::GetScriptOrigin().ResourceName(). More details about v8::Message::GetScriptOrigin(): https://codereview.chromium.org/265593002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280362

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/test/base/v8_unit_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kozyatinskiy1
The patch depends on https://codereview.chromium.org/265593002/ - v8::Message::GetScripOrigin()
6 years, 6 months ago (2014-06-16 09:19:58 UTC) #1
vsevik
lgtm
6 years, 6 months ago (2014-06-16 11:19:11 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-25 06:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/334203002/20001
6 years, 6 months ago (2014-06-25 06:31:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-25 08:50:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 08:53:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/76212)
6 years, 6 months ago (2014-06-25 08:53:09 UTC) #7
vsevik
kalman@, Could you please OWNERS review extensions/ changes. phajdan.jr@, Could you please OWNERS review chrome/test/ ...
6 years, 6 months ago (2014-06-25 11:51:43 UTC) #8
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-25 13:58:10 UTC) #9
vsevik
phajdan.jr@, sky@ Could you please OWNERS review chrome/test/ changes?
6 years, 5 months ago (2014-06-27 12:17:15 UTC) #10
sky
LGTM
6 years, 5 months ago (2014-06-27 18:04:17 UTC) #11
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-06-27 18:12:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/334203002/20001
6 years, 5 months ago (2014-06-27 18:14:34 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 18:18:49 UTC) #14
Message was sent while issue was closed.
Change committed as 280362

Powered by Google App Engine
This is Rietveld 408576698