chrome/test/base/v8_unit_test.cc - Issue 334203002: chrome, extensions: Replaced GetScriptResourceName with GetScriptOrigin().ResourceName()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/v8_unit_test.cc

Issue 334203002: chrome, extensions: Replaced GetScriptResourceName with GetScriptOrigin().ResourceName() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/base/v8_unit_test.cc

diff --git a/chrome/test/base/v8_unit_test.cc b/chrome/test/base/v8_unit_test.cc

index 694c9828f9444dc7bf5ac3c9aec9e368b7d517d1..6cad93dae861885ee5b78c52f99ac345f6e90261 100644

--- a/chrome/test/base/v8_unit_test.cc

+++ b/chrome/test/base/v8_unit_test.cc

@@ -237,7 +237,7 @@ std::string V8UnitTest::ExceptionToString(const v8::TryCatch& try_catch) {

if (message.IsEmpty()) {

str.append(base::StringPrintf("%s\n", *exception));

} else {

- v8::String::Utf8Value filename(message->GetScriptResourceName());

+ v8::String::Utf8Value filename(message->GetScriptOrigin().ResourceName());

int linenum = message->GetLineNumber();

int colnum = message->GetStartColumn();

str.append(base::StringPrintf(

« no previous file with comments | « no previous file | extensions/renderer/module_system.cc » ('j') | no next file with comments »