Issue 334173003: Reuse AstValueFactory when optimizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334173003: Reuse AstValueFactory when optimizing. (Closed)

Created:
6 years, 6 months ago by marja

Modified:
6 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reuse AstValueFactory when optimizing. HOptimizedGraphBuilder::TryInline creates a temporary CompilationInfo and destroys it, but we don't want the AstValueFactory to be destroyed at the same time. Reuse the upper CompilationInfo's AstValueFactory. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21851

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -9 lines)			Patch
M	src/compiler.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/compiler.cc	View	5 chunks	+9 lines, -5 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/parser.cc	View	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 6 months ago (2014-06-16 10:42:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r21851 (tree was closed).

Expand Messages | Collapse Messages