src/hydrogen.cc - Issue 334173003: Reuse AstValueFactory when optimizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 334173003: Reuse AstValueFactory when optimizing. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 658cc5c2f92edeaf2fb44dc30bc3ec3aa2edd30c..9abc0b8006710981b1caf9e5bc7df3375df7cf18 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -7625,6 +7625,9 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,

// Parse and allocate variables.

CompilationInfo target_info(target, zone());

+ // Use the same AstValueFactory for creating strings in the sub-compilation

+ // step, but don't transfer ownership to target_info.

+ target_info.SetAstValueFactory(top_info()->ast_value_factory(), false);

Handle<SharedFunctionInfo> target_shared(target->shared());

if (!Parser::Parse(&target_info) || !Scope::Analyze(&target_info)) {

if (target_info.isolate()->has_pending_exception()) {

« no previous file with comments | « src/compiler.cc ('k') | src/parser.cc » ('j') | no next file with comments »