Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: Source/core/page/ValidationMessageClient.h

Issue 334153003: Oilpan: move page's ValidationMessageClient to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trace() mixing as per GC plugin requirements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/web/ValidationMessageClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/ValidationMessageClient.h
diff --git a/Source/core/page/ValidationMessageClient.h b/Source/core/page/ValidationMessageClient.h
index bb4d009628c92c43c363211277eca4ba112ed1e8..ae2354cd578779bb3d6a26f62cf3ae61fd1db157 100644
--- a/Source/core/page/ValidationMessageClient.h
+++ b/Source/core/page/ValidationMessageClient.h
@@ -26,6 +26,7 @@
#ifndef ValidationMessageClient_h
#define ValidationMessageClient_h
+#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
namespace WebCore {
@@ -33,7 +34,7 @@ namespace WebCore {
class Document;
class Element;
-class ValidationMessageClient {
+class ValidationMessageClient : public WillBeGarbageCollectedMixin {
public:
tkent 2014/06/16 12:48:38 nit: ValidationMessageClient can inherit from Garb
sof 2014/06/16 13:01:26 It definitely could, but I considered that as mixi
tkent 2014/06/16 13:03:39 yeah, it's understandable. You may land this as i
virtual ~ValidationMessageClient() { }
@@ -53,6 +54,8 @@ public:
virtual void documentDetached(const Document&) = 0;
virtual void willBeDestroyed() = 0;
+
+ virtual void trace(Visitor*) { }
};
}
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/web/ValidationMessageClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698