Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: build/android/tombstones.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/valgrind_tools.py ('k') | tools/android/adb_profile_chrome/perf_controller.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/tombstones.py
diff --git a/build/android/tombstones.py b/build/android/tombstones.py
index cb1d700ee099de110e4ac730c73d6a36c79d8441..76dab15b2a7e3a95af46d52b8a298e78ac716789 100755
--- a/build/android/tombstones.py
+++ b/build/android/tombstones.py
@@ -29,8 +29,7 @@ def _ListTombstones(device):
Yields:
Tuples of (tombstone filename, date time of file on device).
"""
- lines = device.old_interface.RunShellCommand(
- 'TZ=UTC su -c ls -a -l /data/tombstones')
+ lines = device.RunShellCommand('TZ=UTC su -c ls -a -l /data/tombstones')
for line in lines:
if 'tombstone' in line and not 'No such file or directory' in line:
details = line.split()
@@ -48,7 +47,7 @@ def _GetDeviceDateTime(device):
Returns:
A datetime instance.
"""
- device_now_string = device.old_interface.RunShellCommand('TZ=UTC date')
+ device_now_string = device.RunShellCommand('TZ=UTC date')
return datetime.datetime.strptime(
device_now_string[0], '%a %b %d %H:%M:%S %Z %Y')
@@ -74,8 +73,8 @@ def _EraseTombstone(device, tombstone_file):
device: An instance of DeviceUtils.
tombstone_file: the tombstone to delete.
"""
- return device.old_interface.RunShellCommandWithSU(
- 'rm /data/tombstones/' + tombstone_file)
+ return device.RunShellCommand(
+ 'rm /data/tombstones/' + tombstone_file, root=True)
def _ResolveSymbols(tombstone_data, include_stack):
« no previous file with comments | « build/android/pylib/valgrind_tools.py ('k') | tools/android/adb_profile_chrome/perf_controller.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698