Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 333853002: IDL parser: add StaticAttribute production (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

IDL parser: add StaticAttribute production This is a straight upstream from Blink's IDL parser, which will allow us to drop some overrides there, which in turn will allow us to update this parser to use the grammar of current Web IDL, where static attributes are supported differently (via a StaticMember production that handles both static attributes and static methods.) Preparation for: IDL parser: drop AttributeOrOperation and StaticAttribute overrides https://codereview.chromium.org/336733002/ (in Blink) ...and ultimately for: IDL parser: align with current Web IDL specification https://codereview.chromium.org/329853005/ BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277843

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/idl_parser/idl_parser.py View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jens Widell
PTAL. Temporary migration patch to make it possible to land https://codereview.chromium.org/329853005/. This patch alone does ...
6 years, 6 months ago (2014-06-13 06:40:02 UTC) #1
Nils Barth (inactive)
On 2014/06/13 06:40:02, Jens Lindström wrote: > PTAL. > > Temporary migration patch to make ...
6 years, 6 months ago (2014-06-16 06:59:19 UTC) #2
Nils Barth (inactive)
LGTM, thanks! AFAICT, this is the *first* CL in this sequence. https://codereview.chromium.org/333853002/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): ...
6 years, 6 months ago (2014-06-16 06:59:40 UTC) #3
Nils Barth (inactive)
Noel, looks ok?
6 years, 6 months ago (2014-06-16 07:00:01 UTC) #4
noelallen1
lgtm
6 years, 6 months ago (2014-06-17 15:54:38 UTC) #5
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-17 15:56:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/333853002/20001
6 years, 6 months ago (2014-06-17 15:57:55 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 20:16:19 UTC) #8
Message was sent while issue was closed.
Change committed as 277843

Powered by Google App Engine
This is Rietveld 408576698