Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 336733002: IDL parser: drop AttributeOrOperation and StaticAttribute overrides (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL parser: drop AttributeOrOperation and StaticAttribute overrides Static attributes are now supported by the base IDL parser, so these overrides are no longer needed. Followup to: IDL parser: add StaticAttribute production https://codereview.chromium.org/333853002/ ...and prep for: IDL parser: align with current Web IDL specification https://codereview.chromium.org/329853005/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M Source/bindings/scripts/blink_idl_parser.py View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
PTAL. Possible once https://codereview.chromium.org/333853002/ has landed.
6 years, 6 months ago (2014-06-13 06:40:59 UTC) #1
haraken
LGTM (once the base parser change lands).
6 years, 6 months ago (2014-06-13 06:48:57 UTC) #2
Nils Barth (inactive)
LGTM Noel, looks ok? AFAICT, this is the *second* CL in this sequence.
6 years, 6 months ago (2014-06-16 07:00:22 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-18 05:48:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/336733002/1
6 years, 6 months ago (2014-06-18 05:48:43 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 06:52:43 UTC) #6
Message was sent while issue was closed.
Change committed as 176398

Powered by Google App Engine
This is Rietveld 408576698