Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 333763002: Revert of third try at landing improved blur rect; this time with more correctness (Closed)

Created:
6 years, 6 months ago by scroggo
Modified:
6 years, 6 months ago
Reviewers:
humper, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of third try at landing improved blur rect; this time with more correctness (https://codereview.chromium.org/331443003/) Reason for revert: Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html Original issue's description: > third try at landing improved blur rect; this time with more correctness > > BUG=skia:2095 > R=bsalomon@google.com > TBR=bsalomon > > Committed: https://skia.googlesource.com/skia/+/72abfc2b4e7caead660f6b6a05e60d05eaf1a66f TBR=bsalomon@google.com,reed@google.com,humper@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2095 Committed: https://skia.googlesource.com/skia/+/e07c1ab40882078b505f2b0ceb7413c44af569e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -125 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 8 chunks +101 lines, -104 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BlurTest.cpp View 4 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of third try at landing improved blur rect; this time with more correctness
6 years, 6 months ago (2014-06-12 19:10:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/333763002/1
6 years, 6 months ago (2014-06-12 19:10:17 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 19:10:29 UTC) #3
Message was sent while issue was closed.
Change committed as e07c1ab40882078b505f2b0ceb7413c44af569e8

Powered by Google App Engine
This is Rietveld 408576698