Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 333723002: Componentize google_util (Closed)

Created:
6 years, 6 months ago by blundell
Modified:
6 years, 6 months ago
CC:
asvitkine+watch_chromium.org, ben+ash_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dbeam+watch-ntp_chromium.org, dbeam+watch-options_chromium.org, David Black, dhollowa+watch_chromium.org, dominich, donnd+watch_chromium.org, dougw+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, haitaol+watch_chromium.org, Ilya Sherman, jam, Jered, jfweitz+watch_chromium.org, kalyank, kmadhusu+watch_chromium.org, maniscalco+watch_chromium.org, mcasas+watch_chromium.org, melevin+watch_chromium.org, miu+watch_chromium.org, Michael van Ouwerkerk, nkostylev+watch_chromium.org, oshima+watch_chromium.org, pedrosimonetti+watch_chromium.org, sadrul, samarth+watch_chromium.org, skanuj+watch_chromium.org, stevenjb+watch_chromium.org, stuartmorgan+watch_chromium.org, James Su, tfarina, tim+watch_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Componentize google_util Also removes the indirection through the client that GoogleURLTracker was previously doing to call a google_util function. BUG=373245, 381088 TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278448

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add test implementation of infobar methods #

Patch Set 4 : Rebase #

Patch Set 5 : Build fixes #

Patch Set 6 : Remove unittest componentization #

Patch Set 7 : Rebase + build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -416 lines) Patch
M chrome/browser/android/logo_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/android/url_utilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/chrome_google_url_tracker_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google/chrome_google_url_tracker_client.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/google/google_profile_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_search_counter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 3 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/google/google_util.h View 1 2 3 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/google/google_util.cc View 1 2 3 1 chunk +0 lines, -217 lines 0 comments Download
M chrome/browser/google/google_util_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/insecure_content_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_http_header_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/net/evicted_domain_cookie_counter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_promo.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/navigation_correction_tab_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_reset_bubble_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/google.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M components/google/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 2 chunks +4 lines, -1 line 0 comments Download
M components/google/core/browser/google_url_tracker_client.h View 1 chunk +0 lines, -6 lines 0 comments Download
A + components/google/core/browser/google_util.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/google/core/browser/google_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
blundell
6 years, 6 months ago (2014-06-12 17:17:25 UTC) #1
Peter Kasting
LGTM
6 years, 6 months ago (2014-06-12 17:44:26 UTC) #2
blundell
TBR=jochen for //chrome outside of //chrome/browser/google
6 years, 6 months ago (2014-06-13 05:14:47 UTC) #3
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-13 05:16:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/333723002/1
6 years, 6 months ago (2014-06-13 05:18:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 07:50:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 07:53:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/161037) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/22385) mac_chromium_compile_dbg ...
6 years, 6 months ago (2014-06-13 07:53:40 UTC) #8
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-13 08:03:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/333723002/20001
6 years, 6 months ago (2014-06-13 08:04:22 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 12:00:14 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 12:10:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/161060)
6 years, 6 months ago (2014-06-13 12:10:51 UTC) #13
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-18 03:51:44 UTC) #14
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-19 15:17:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/333723002/130001
6 years, 6 months ago (2014-06-19 15:19:19 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 19:03:33 UTC) #17
Message was sent while issue was closed.
Change committed as 278448

Powered by Google App Engine
This is Rietveld 408576698