components/google/core/browser/google_url_tracker_client.h - Issue 333723002: Componentize google_util

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/google/core/browser/google_url_tracker_client.h

Issue 333723002: Componentize google_util (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + build fix Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/google/core/browser/google_url_tracker_client.h

diff --git a/components/google/core/browser/google_url_tracker_client.h b/components/google/core/browser/google_url_tracker_client.h

index 81f9a1e9f2592e73106f2b11a0ee6bceb7d2f5c2..45c101b5fabfb26d41bd97c9059932afb8c551c9 100644

--- a/components/google/core/browser/google_url_tracker_client.h

+++ b/components/google/core/browser/google_url_tracker_client.h

@@ -44,12 +44,6 @@ class GoogleURLTrackerClient {

// should use.

virtual net::URLRequestContextGetter* GetRequestContext() = 0;

- // Returns whether |url| is for a Google domain.

- // TODO(blundell): Eliminate this method in favor of having callers call

- // google_util::IsGoogleDomainURL() directly once google_util is

- // componentized. crbug.com/381088

- virtual bool IsGoogleDomainURL(const GURL& url) = 0;

protected:

GoogleURLTracker* google_url_tracker() { return google_url_tracker_; }