Move event stuff of web_view.js to its own class/file.

Move event stuff of web_view.js to its own class/file.

Make event filtered by viewInstanceId instead of instanceId for guests.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278627

[lazyboy, 2014-06-17 03:02:39]

Hey Fady, can you skim through the code a bit?
I'm trying to move event related code out of web_view.js to web_view_events.js
(need a better name).

WebViewEvents would have pointer/ref to WebViewInternal, but no back pointer,
any update required to propagate to WebViewInternal from
WebViewEvents can happen through this ref.

Filtering events by viewInstanceId is also done, this means we can
register events right in the beginning and don't have to wait until
attach.

I'll keep working on this if you feel this is not undesirable, thanks.

[lazyboy, 2014-06-18 03:03:45]

This should be good to be reviewed now, PTAL.

[Fady Samuel, 2014-06-19 14:25:26]

This largely looks like it's just moving code so that's fine by me. lgtm

https://codereview.chromium.org/333713005/diff/80001/chrome/renderer/resource...
File chrome/renderer/resources/extensions/web_view_events.js (right):

https://codereview.chromium.org/333713005/diff/80001/chrome/renderer/resource...
chrome/renderer/resources/extensions/web_view_events.js:22: // WEB_VIEW_EVENTS
is a map of stable <webview> DOM event names to their
Move this above WEB_VIEW_EVENTS directly.

[lazyboy, 2014-06-19 16:09:42]

+kalman for
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc+sky for	
chrome/renderer/resources/renderer_resources.grd

[not at google - send to devlin, 2014-06-19 17:30:35]

chrome_extensions_dispatcher_delegate.cc lgtm

[sky, 2014-06-19 20:17:40]

.grd LGTM

[lazyboy, 2014-06-20 01:33:22]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2014-06-20 01:37:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lazyboy@chromium.org/333713005/100001

[commit-bot: I haz the power, 2014-06-20 02:27:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-20 02:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 02:36:14]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[lazyboy, 2014-06-20 04:29:52]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2014-06-20 04:31:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lazyboy@chromium.org/333713005/100001

[commit-bot: I haz the power, 2014-06-20 05:44:08]

Change committed as 278627