chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc - Issue 333713005: Move event stuff of web_view.js to its own class/file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

Issue 333713005: Move event stuff of web_view.js to its own class/file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from fady Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

diff --git a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

index 96146c4570cb20245add7f7794eef5565a2e6cbd..08fbf5bd4a9aaf327b08233f62e29685642ec06e 100644

--- a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

+++ b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

@@ -240,6 +240,7 @@ void ChromeExtensionsDispatcherDelegate::PopulateSourceMap(

// Note: webView not webview so that this doesn't interfere with the

// chrome.webview API bindings.

source_map->RegisterSource("webView", IDR_WEB_VIEW_JS);

+ source_map->RegisterSource("webViewEvents", IDR_WEB_VIEW_EVENTS_JS);

source_map->RegisterSource("webViewExperimental",

IDR_WEB_VIEW_EXPERIMENTAL_JS);

source_map->RegisterSource("webViewRequest",

« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »