Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 333643009: Revert 276260 "Win Video Capture: Add support for HDYC pixel for..." (Closed)

Created:
6 years, 6 months ago by mcasas
Modified:
6 years, 6 months ago
Reviewers:
Dominik Grewe, mcasas
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 276260 "Win Video Capture: Add support for HDYC pixel for..." > Win Video Capture: Add support for HDYC pixel format. > > This pixel format is a synonym of YUYV and is needed > for at least the DeckLink video capture card. > This format is not specified in Windows headers > probably because this is just a synonym of other > pixel formats, IOW they are all the same except for > the first word, which is the name read in hex > backwards: > 30323449 --> 0x30 0x32 0x34 0x49 -> 024I > 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH > > and then all the YUV (422 and 420 alike) use the same > trailing sequence > ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}} > > HDYC: http://www.fourcc.org/yuv.php#HDYC > > BUG=380939 > > Review URL: https://codereview.chromium.org/317073010 TBR=mcasas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278314

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M trunk/src/media/video/capture/win/sink_filter_win.h View 1 chunk +2 lines, -6 lines 0 comments Download
M trunk/src/media/video/capture/win/sink_filter_win.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M trunk/src/media/video/capture/win/video_capture_device_factory_win.cc View 2 chunks +1 line, -3 lines 1 comment Download
M trunk/src/media/video/capture/win/video_capture_device_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mcasas
6 years, 6 months ago (2014-06-19 09:39:57 UTC) #1
mcasas
Committed patchset #1 manually as r278314 (tree was closed).
6 years, 6 months ago (2014-06-19 09:40:43 UTC) #2
Dominik Grewe
6 years, 6 months ago (2014-06-19 10:17:38 UTC) #3
Message was sent while issue was closed.
https://codereview.chromium.org/333643009/diff/1/trunk/src/media/video/captur...
File trunk/src/media/video/capture/win/video_capture_device_factory_win.cc
(left):

https://codereview.chromium.org/333643009/diff/1/trunk/src/media/video/captur...
trunk/src/media/video/capture/win/video_capture_device_factory_win.cc:223:
std::string id;
Removing this line is causing a compile failure. Can you either please add it
back or remove the part of the code using the 'id' variable (which was
introduced by the CL you're reverting afaict)?

Powered by Google App Engine
This is Rietveld 408576698