Source/core/rendering/style/RenderStyle.h - Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.h

Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New version Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html ('K') | « Source/core/rendering/style/GridResolvedPosition.cpp ('k') | Source/core/rendering/style/RenderStyleConstants.h » ('j') | Source/core/rendering/style/RenderStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/style/RenderStyle.h

diff --git a/Source/core/rendering/style/RenderStyle.h b/Source/core/rendering/style/RenderStyle.h

index 543c815d06d3b4f7dcecd875e64d39f0c1409312..02720fc7300453abd738d709d76a720e204a707d 100644

--- a/Source/core/rendering/style/RenderStyle.h

+++ b/Source/core/rendering/style/RenderStyle.h

@@ -796,6 +796,11 @@ public:

size_t namedGridAreaRowCount() const { return rareNonInheritedData->m_grid->m_namedGridAreaRowCount; }

size_t namedGridAreaColumnCount() const { return rareNonInheritedData->m_grid->m_namedGridAreaColumnCount; }

GridAutoFlow gridAutoFlow() const { return rareNonInheritedData->m_grid->m_gridAutoFlow; }

+ bool isGridAutoFlowDirectionRow() const { return (rareNonInheritedData->m_grid->m_gridAutoFlow & AutoFlowDirectionRow) == AutoFlowDirectionRow; }

+ bool isGridAutoFlowDirectionColumn() const { return (rareNonInheritedData->m_grid->m_gridAutoFlow & AutoFlowDirectionColumn) == AutoFlowDirectionColumn; }

+ bool isGridAutoFlowAlgorithmSparse() const { return (rareNonInheritedData->m_grid->m_gridAutoFlow & AutoFlowAlgorithmSparse) == AutoFlowAlgorithmSparse; }

+ bool isGridAutoFlowAlgorithmDense() const { return (rareNonInheritedData->m_grid->m_gridAutoFlow & AutoFlowAlgorithmDense) == AutoFlowAlgorithmDense; }

+ bool isGridAutoFlowAlgorithmStack() const { return (rareNonInheritedData->m_grid->m_gridAutoFlow & AutoFlowAlgorithmStack) == AutoFlowAlgorithmStack; }

const GridTrackSize& gridAutoColumns() const { return rareNonInheritedData->m_grid->m_gridAutoColumns; }

const GridTrackSize& gridAutoRows() const { return rareNonInheritedData->m_grid->m_gridAutoRows; }

@@ -1676,7 +1681,7 @@ public:

static Vector<GridTrackSize> initialGridTemplateColumns() { return Vector<GridTrackSize>(); }

static Vector<GridTrackSize> initialGridTemplateRows() { return Vector<GridTrackSize>(); }

- static GridAutoFlow initialGridAutoFlow() { return AutoFlowNone; }

+ static GridAutoFlow initialGridAutoFlow() { return AutoFlowRow; }

static GridTrackSize initialGridAutoColumns() { return GridTrackSize(Length(Auto)); }

static GridTrackSize initialGridAutoRows() { return GridTrackSize(Length(Auto)); }