Source/core/rendering/style/GridResolvedPosition.cpp - Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/GridResolvedPosition.cpp

Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Small fix in add/removeChild to avoid dirtying the grid in stack Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/rendering/RenderGrid.cpp ('k') | Source/core/rendering/style/RenderStyle.h » ('j') | Source/core/rendering/style/RenderStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/style/GridResolvedPosition.cpp

diff --git a/Source/core/rendering/style/GridResolvedPosition.cpp b/Source/core/rendering/style/GridResolvedPosition.cpp

index b537048b75c5eae3a8ca4596d09102000d161699..b0415db18a122788a0766195fea59152bf24ac8d 100644

--- a/Source/core/rendering/style/GridResolvedPosition.cpp

+++ b/Source/core/rendering/style/GridResolvedPosition.cpp

@@ -94,7 +94,8 @@ PassOwnPtr<GridSpan> GridResolvedPosition::resolveGridPositionsFromStyle(const R

GridPositionSide finalPositionSide = calculateFinalPositionSide(direction);

if (initialPosition.shouldBeResolvedAgainstOppositePosition() && finalPosition.shouldBeResolvedAgainstOppositePosition()) {

- if (gridContainerStyle.gridAutoFlow() == AutoFlowNone)

+ // FIXME: Implement properly "stack" value in auto-placement algorithm.

+ if (gridContainerStyle.gridAutoFlow() == AutoFlowStackColumn || gridContainerStyle.gridAutoFlow() == AutoFlowStackRow)

return adoptPtr(new GridSpan(0, 0));

// We can't get our grid positions without running the auto placement algorithm.