Source/core/css/parser/BisonCSSParser-in.cpp - Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Small fix in add/removeChild to avoid dirtying the grid in stack Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html ('K') | « Source/core/css/CSSValueKeywords.in ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/BisonCSSParser-in.cpp

diff --git a/Source/core/css/parser/BisonCSSParser-in.cpp b/Source/core/css/parser/BisonCSSParser-in.cpp

index 35e28e2d20afad68e7c5e15d0494f56efdae9528..7ffd7a5cca3219cd4c7aefd07a8dec8a95327a66 100644

--- a/Source/core/css/parser/BisonCSSParser-in.cpp

+++ b/Source/core/css/parser/BisonCSSParser-in.cpp

@@ -525,9 +525,6 @@ bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, CSSValueID valueID

return valueID == CSSValueAuto || valueID == CSSValueNormal || valueID == CSSValueNone;

case CSSPropertyWebkitFontSmoothing:

return valueID == CSSValueAuto || valueID == CSSValueNone || valueID == CSSValueAntialiased || valueID == CSSValueSubpixelAntialiased;

- case CSSPropertyGridAutoFlow:

- return RuntimeEnabledFeatures::cssGridLayoutEnabled()

- && (valueID == CSSValueNone || valueID == CSSValueRow || valueID == CSSValueColumn);

case CSSPropertyWebkitLineBreak: // auto | loose | normal | strict | after-white-space

return valueID == CSSValueAuto || valueID == CSSValueLoose || valueID == CSSValueNormal || valueID == CSSValueStrict || valueID == CSSValueAfterWhiteSpace;

case CSSPropertyWebkitMarginAfterCollapse:

@@ -656,7 +653,6 @@ bool isKeywordPropertyID(CSSPropertyID propertyId)

case CSSPropertyJustifyContent:

case CSSPropertyFontKerning:

case CSSPropertyWebkitFontSmoothing:

- case CSSPropertyGridAutoFlow:

case CSSPropertyWebkitLineBreak:

case CSSPropertyWebkitMarginAfterCollapse:

case CSSPropertyWebkitMarginBeforeCollapse: