Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 33353003: Have Frame::tree() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/StorageAreaProxy.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebFrameImpl.cpp
diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp
index 00a5b3beb401f3b4a3e89f0d3d09bdeaf5bd214a..f19c80e9365778e5d3207f124906899066edb757 100644
--- a/Source/web/WebFrameImpl.cpp
+++ b/Source/web/WebFrameImpl.cpp
@@ -241,8 +241,8 @@ static void frameContentAsPlainText(size_t maxChars, Frame* frame, StringBuilder
const size_t frameSeparatorLength = WTF_ARRAY_LENGTH(frameSeparator);
// Recursively walk the children.
- FrameTree* frameTree = frame->tree();
- for (Frame* curChild = frameTree->firstChild(); curChild; curChild = curChild->tree()->nextSibling()) {
+ const FrameTree& frameTree = frame->tree();
+ for (Frame* curChild = frameTree.firstChild(); curChild; curChild = curChild->tree().nextSibling()) {
// Ignore the text of non-visible frames.
RenderView* contentRenderer = curChild->contentRenderer();
RenderPart* ownerRenderer = curChild->ownerRenderer();
@@ -529,17 +529,17 @@ void WebFrameImpl::close()
WebString WebFrameImpl::uniqueName() const
{
- return frame()->tree()->uniqueName();
+ return frame()->tree().uniqueName();
}
WebString WebFrameImpl::assignedName() const
{
- return frame()->tree()->name();
+ return frame()->tree().name();
}
void WebFrameImpl::setName(const WebString& name)
{
- frame()->tree()->setName(name);
+ frame()->tree().setName(name);
}
long long WebFrameImpl::embedderIdentifier() const
@@ -632,63 +632,63 @@ WebFrame* WebFrameImpl::parent() const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->parent());
+ return fromFrame(frame()->tree().parent());
}
WebFrame* WebFrameImpl::top() const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->top());
+ return fromFrame(frame()->tree().top());
}
WebFrame* WebFrameImpl::firstChild() const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->firstChild());
+ return fromFrame(frame()->tree().firstChild());
}
WebFrame* WebFrameImpl::lastChild() const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->lastChild());
+ return fromFrame(frame()->tree().lastChild());
}
WebFrame* WebFrameImpl::nextSibling() const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->nextSibling());
+ return fromFrame(frame()->tree().nextSibling());
}
WebFrame* WebFrameImpl::previousSibling() const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->previousSibling());
+ return fromFrame(frame()->tree().previousSibling());
}
WebFrame* WebFrameImpl::traverseNext(bool wrap) const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->traverseNextWithWrap(wrap));
+ return fromFrame(frame()->tree().traverseNextWithWrap(wrap));
}
WebFrame* WebFrameImpl::traversePrevious(bool wrap) const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->traversePreviousWithWrap(wrap));
+ return fromFrame(frame()->tree().traversePreviousWithWrap(wrap));
}
WebFrame* WebFrameImpl::findChildByName(const WebString& name) const
{
if (!frame())
return 0;
- return fromFrame(frame()->tree()->child(name));
+ return fromFrame(frame()->tree().child(name));
}
WebFrame* WebFrameImpl::findChildByExpression(const WebString& xpath) const
@@ -1832,7 +1832,7 @@ bool WebFrameImpl::isActiveMatchFrameValid() const
{
WebFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl();
WebFrameImpl* activeMatchFrame = mainFrameImpl->activeMatchFrame();
- return activeMatchFrame && activeMatchFrame->m_activeMatch && activeMatchFrame->frame()->tree()->isDescendantOf(mainFrameImpl->frame());
+ return activeMatchFrame && activeMatchFrame->m_activeMatch && activeMatchFrame->frame()->tree().isDescendantOf(mainFrameImpl->frame());
}
void WebFrameImpl::updateFindMatchRects()
@@ -2173,9 +2173,9 @@ PassRefPtr<Frame> WebFrameImpl::createChildFrame(const FrameLoadRequest& request
RefPtr<Frame> childFrame = Frame::create(frame()->page(), ownerElement, &webframe->m_frameLoaderClient);
webframe->setWebCoreFrame(childFrame.get());
- childFrame->tree()->setName(request.frameName());
+ childFrame->tree().setName(request.frameName());
- frame()->tree()->appendChild(childFrame);
+ frame()->tree().appendChild(childFrame);
// FIXME: Remove once all embedders return non-null from createChildFrame().
if (mustCallDidCreateFrame)
@@ -2192,7 +2192,7 @@ PassRefPtr<Frame> WebFrameImpl::createChildFrame(const FrameLoadRequest& request
// NOTE: m_client will be null if this frame has been detached.
// (b:791612)
childFrame->init(); // create an empty document
- if (!childFrame->tree()->parent())
+ if (!childFrame->tree().parent())
return 0;
HistoryItem* parentItem = frame()->loader()->history()->currentItem();
@@ -2200,7 +2200,7 @@ PassRefPtr<Frame> WebFrameImpl::createChildFrame(const FrameLoadRequest& request
// If we're moving in the back/forward list, we might want to replace the content
// of this child frame with whatever was there at that point.
if (parentItem && parentItem->children().size() && isBackForwardLoadType(frame()->loader()->loadType()) && !frame()->document()->loadEventFinished())
- childItem = parentItem->childItemWithTarget(childFrame->tree()->uniqueName());
+ childItem = parentItem->childItemWithTarget(childFrame->tree().uniqueName());
if (childItem)
childFrame->loader()->loadHistoryItem(childItem);
@@ -2211,7 +2211,7 @@ PassRefPtr<Frame> WebFrameImpl::createChildFrame(const FrameLoadRequest& request
// onload, so it is possible for the frame to have already been destroyed by
// script in the page.
// NOTE: m_client will be null if this frame has been detached.
- if (!childFrame->tree()->parent())
+ if (!childFrame->tree().parent())
return 0;
return childFrame.release();
« no previous file with comments | « Source/web/StorageAreaProxy.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698