Source/core/rendering/RenderGrid.cpp - Issue 333423005: [CSS Grid Layout] Implement 'justify-items' parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 333423005: [CSS Grid Layout] Implement 'justify-items' parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied suggested changes. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/rendering/RenderFlexibleBox.cpp ('k') | Source/core/rendering/style/RenderStyle.h » ('j') | Source/core/rendering/style/RenderStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderGrid.cpp

diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp

index 83059ac6bcbe342ba9848fdeb3416ab3463c5ccd..66a6f82f62b1f6eec1bd14a2c8510adaa90c75dd 100644

--- a/Source/core/rendering/RenderGrid.cpp

+++ b/Source/core/rendering/RenderGrid.cpp

@@ -1160,6 +1160,7 @@ LayoutUnit RenderGrid::columnPositionForChild(const RenderBox* child) const

case ItemPositionAuto:

case ItemPositionStretch:

case ItemPositionBaseline:

+ case ItemPositionLastBaseline:

// FIXME: Implement the previous values. For now, we always start align the child.

return startOfColumnForChild(child);

}