Source/core/rendering/style/RenderStyleConstants.h - Issue 333423005: [CSS Grid Layout] Implement 'justify-items' parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyleConstants.h

Issue 333423005: [CSS Grid Layout] Implement 'justify-items' parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied suggested changes. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/rendering/style/RenderStyle.h ('k') | Source/core/rendering/style/StyleRareNonInheritedData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/style/RenderStyleConstants.h

diff --git a/Source/core/rendering/style/RenderStyleConstants.h b/Source/core/rendering/style/RenderStyleConstants.h

index f2a3d006af036e457d5c3ae846a64704f457eb93..83740d2804d7f52e6f7ed3375a45c0cdfcdd1a83 100644

--- a/Source/core/rendering/style/RenderStyleConstants.h

+++ b/Source/core/rendering/style/RenderStyleConstants.h

@@ -508,6 +508,7 @@ enum ItemPosition {

ItemPositionAuto,

ItemPositionStretch,

ItemPositionBaseline,

+ ItemPositionLastBaseline,

ItemPositionCenter,

ItemPositionStart,

ItemPositionEnd,

@@ -525,6 +526,11 @@ enum OverflowAlignment {

OverflowAlignmentSafe

};

+enum LegacyPosition {

+ LegacyPositionFalse,

+ LegacyPositionTrue

Julien - ping for review 2014/06/26 17:37:20 Maybe better naming LegacyPosition vs NotALegacyPo

jfernandez 2014/06/26 22:36:05 Done.

+};

// Reasonable maximum to prevent insane font sizes from causing crashes on some platforms (such as Windows).

static const float maximumAllowedFontSize = 1000000.0f;