Issue 333403007: Revert 277743 "[Mac] Add interactive App Shim test."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333403007: Revert 277743 "[Mac] Add interactive App Shim test." (Closed)

Created:
6 years, 6 months ago by macourteau

Modified:
6 years, 6 months ago

Reviewers:
jackhou1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 277743 "[Mac] Add interactive App Shim test." Failed test: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/50667/steps/interactive_ui_tests/logs/stdio The new test appears to be timing out on the bots. > [Mac] Add interactive App Shim test. > > This test creates shims in the user data dir and actually starts them up and > expects them to connect to the IPC socket. > > BUG=168080 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276368 > > Review URL: https://codereview.chromium.org/316493002 TBR=jackhou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277754

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -328 lines)			Patch
D	trunk/src/apps/app_shim/app_shim_interactive_uitest_mac.mm	View	1 chunk	+0 lines, -300 lines	0 comments	Download
M	trunk/src/apps/app_shim/chrome_main_app_mode_mac.mm	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	trunk/src/chrome/app/app_mode-Info.plist	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/web_applications/web_app_mac.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/web_applications/web_app_mac.mm	View	4 chunks	+2 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/mac/app_mode_common.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/common/mac/app_mode_common.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

macourteau

6 years, 6 months ago (2014-06-17 14:39:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r277754 (tree was closed).