Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/apps/app_shim/chrome_main_app_mode_mac.mm

Issue 333403007: Revert 277743 "[Mac] Add interactive App Shim test." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/apps/app_shim/app_shim_interactive_uitest_mac.mm ('k') | trunk/src/chrome/app/app_mode-Info.plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/apps/app_shim/chrome_main_app_mode_mac.mm
===================================================================
--- trunk/src/apps/app_shim/chrome_main_app_mode_mac.mm (revision 277753)
+++ trunk/src/apps/app_shim/chrome_main_app_mode_mac.mm (working copy)
@@ -611,11 +611,7 @@
main_message_loop.set_thread_name("MainThread");
base::PlatformThread::SetName("CrAppShimMain");
- // In tests, launching Chrome does nothing, and we won't get a ping response,
- // so just assume the socket exists.
- if (pid == -1 &&
- !CommandLine::ForCurrentProcess()->HasSwitch(
- app_mode::kLaunchedForTest)) {
+ if (pid == -1) {
// Launch Chrome if it isn't already running.
ProcessSerialNumber psn;
CommandLine command_line(CommandLine::NO_PROGRAM);
« no previous file with comments | « trunk/src/apps/app_shim/app_shim_interactive_uitest_mac.mm ('k') | trunk/src/chrome/app/app_mode-Info.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698