Fix the Windows 8 mode avatar button menu.

Fix the Windows 8 mode avatar button menu.

Metro's avatar button is no-op w/--new-profile-management.
This may have regressed with r270126, but I'm not sure how.

IsNewAvatarMenu returns true in metro (r263677, r263396).
However, GetNewAvatarMenuButton returns NULL in metro.
(the new button isn't implemented for that frame, afaict)
So ShowAvatarBubbleFromAvatarButton currently does nothing.
Instead, anchor to the avatar menu button or app menu.

Remove the unused |anchor_rect| parameter.

BUG=382895
R=noms@chromium.org,sky@chromium.org
TEST=Avatar button works in Windows 8 mode (metro) with .

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277857

[msw, 2014-06-16 22:49:53]

Please take a look; lmk if we should do something else, like:
1) Use the old menu if the new button doesn't exist like PS1?
2) Make IsNewAvatarMenu always return false in Win8 metro?
3) Implement the new menu button in Win8 metro.
I'm not entirely sure what's intended here.

[noms (inactive), 2014-06-17 14:16:54]

Does the new menu button not work in Win8 metro? Is there a limitaton why it
doesn't just work? 
It exists for Win8 "regular mode", but I know far too little about Win8 to
understand the 
differences.

Just to confirm, though: if the --new-profile-management flag isn't enabled, we
display the "old style"
avatar menu, right (i.e. the little avatar head)?

On 2014/06/16 22:49:53, msw wrote:
> Please take a look; lmk if we should do something else, like:
> 1) Use the old menu if the new button doesn't exist like PS1?
> 2) Make IsNewAvatarMenu always return false in Win8 metro?
> 3) Implement the new menu button in Win8 metro.
> I'm not entirely sure what's intended here.

[msw, 2014-06-17 18:16:45]

On 2014/06/17 14:16:54, Monica Dinculescu wrote:
> Does the new menu button not work in Win8 metro? Is there a limitaton why it
> doesn't just work? 
> It exists for Win8 "regular mode", but I know far too little about Win8 to
> understand the 
> differences.
> 
> Just to confirm, though: if the --new-profile-management flag isn't enabled,
we
> display the "old style"
> avatar menu, right (i.e. the little avatar head)?

On 36.0.1985.67 (Official Build 276210) beta-m with no flags:
-Windows 8 desktop and metro show the old button (avatar) and old bubble.
On 36.0.1985.67 (Official Build 276210) beta-m w/--new-profile-management:
-Windows 8 desktop shows the new button (name) and the new menu.
-Windows 8 metro shows the *old* button (avatar) and the *new* menu.
(see the expected screenshot on the bug report for what this looks like)

This CL restores the above behavior, which regressed between beta and dev.
I'm not sure offhand why the new button is not being used on Metro.
That separate defect should be fixed separately; I can help if needed.

[noms (inactive), 2014-06-17 18:19:06]

I see. lgtm. 
I will investigate what's up with the new button.

[msw, 2014-06-17 18:21:09]

+Scott for OWNERS, please take a look; thanks!

[sky, 2014-06-17 19:14:53]

LGTM

[msw, 2014-06-17 19:22:50]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-06-17 19:24:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/333353004/20001

[commit-bot: I haz the power, 2014-06-17 20:38:33]

Change committed as 277857