Fix the Windows 8 mode avatar button menu.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 2361 matching lines @@
   gfx::Rect bounds(origin, rect.size());
 
   AvatarMenuBubbleView::ShowBubble(
       this, views::BubbleBorder::TOP_RIGHT, views::BubbleBorder::PAINT_NORMAL,
       views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE, bounds, browser_.get());
 }
 
 void BrowserView::ShowAvatarBubbleFromAvatarButton(
     AvatarBubbleMode mode,
     signin::GAIAServiceType service_type) {
+  views::BubbleBorder::Arrow arrow = views::BubbleBorder::TOP_RIGHT;
+  views::BubbleBorder::BubbleAlignment alignment =
+    views::BubbleBorder::ALIGN_ARROW_TO_MID_ANCHOR;
+  views::View* anchor_view = frame_->GetAvatarMenuButton();
+  if (!anchor_view)
+    anchor_view = toolbar_->app_menu();
+  else if (!frame_->GetAvatarMenuButton()->button_on_right())
+    arrow = views::BubbleBorder::TOP_LEFT;
+
   if (switches::IsNewAvatarMenu()) {
     NewAvatarButton* button = frame_->GetNewAvatarMenuButton();
     if (button) {
-      gfx::Point origin;
-      views::View::ConvertPointToScreen(button, &origin);
-      gfx::Rect bounds(origin, size());
+      anchor_view = button;
+      arrow = views::BubbleBorder::TOP_RIGHT;
+      alignment = views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE;
+    }
 
-      profiles::BubbleViewMode view_mode;
-      switch (mode) {
-        case AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT:
-          view_mode = profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT;
-          break;
-        case AVATAR_BUBBLE_MODE_SIGNIN:
-          view_mode = profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN;
-          break;
-        case AVATAR_BUBBLE_MODE_REAUTH:
-          view_mode = profiles::BUBBLE_VIEW_MODE_GAIA_REAUTH;
-          break;
-        default:
-          view_mode = profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
-          break;
-      }
-      ProfileChooserView::ShowBubble(
-          view_mode, service_type, button, views::BubbleBorder::TOP_RIGHT,
-          views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE, bounds, browser());
+    profiles::BubbleViewMode view_mode;
+    switch (mode) {
+      case AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT:
+        view_mode = profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT;
+        break;
+      case AVATAR_BUBBLE_MODE_SIGNIN:
+        view_mode = profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN;
+        break;
+      case AVATAR_BUBBLE_MODE_REAUTH:
+        view_mode = profiles::BUBBLE_VIEW_MODE_GAIA_REAUTH;
+        break;
+      default:
+        view_mode = profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
+        break;
     }
+    ProfileChooserView::ShowBubble(view_mode, service_type, anchor_view, arrow,
+                                   alignment, browser());
   } else {
-    views::BubbleBorder::Arrow arrow = views::BubbleBorder::TOP_RIGHT;
-    views::View* anchor_view = frame_->GetAvatarMenuButton();
-    if (!anchor_view)
-      anchor_view = toolbar_->app_menu();
-    else if (!frame_->GetAvatarMenuButton()->button_on_right())
-      arrow = views::BubbleBorder::TOP_LEFT;
     gfx::Point origin;
     views::View::ConvertPointToScreen(anchor_view, &origin);
     gfx::Rect bounds(origin, anchor_view->size());
     views::BubbleBorder::ArrowPaintType arrow_paint_type =
         ShouldHideUIForFullscreen() ? views::BubbleBorder::PAINT_TRANSPARENT :
                                       views::BubbleBorder::PAINT_NORMAL;
     AvatarMenuBubbleView::ShowBubble(anchor_view, arrow, arrow_paint_type,
-        views::BubbleBorder::ALIGN_ARROW_TO_MID_ANCHOR, bounds, browser());
+                                     alignment, bounds, browser());
     ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ICON_AVATAR_BUBBLE);
   }
 }
 
 void BrowserView::ShowPasswordGenerationBubble(
     const gfx::Rect& rect,
     const autofill::PasswordForm& form,
     autofill::PasswordGenerator* password_generator) {
   // Create a rect in the content bounds that the bubble will point to.
   gfx::Point origin(rect.origin());
@@ skipping 112 matching lines @@
       !GetLocationBar()->GetOmniboxView()->model()->popup_model()->IsOpen()) {
     gfx::Point icon_bottom(
         toolbar_->location_bar()->GetLocationBarAnchorPoint());
     ConvertPointToTarget(toolbar_->location_bar(), this, &icon_bottom);
     gfx::Point infobar_top(0, infobar_container_->GetVerticalOverlap(NULL));
     ConvertPointToTarget(infobar_container_, this, &infobar_top);
     top_arrow_height = infobar_top.y() - icon_bottom.y();
   }
   return top_arrow_height;
 }