Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 333313002: Oilpan: move a page's UndoStack to the heap. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: move a page's UndoStack to the heap. Avoids its unnecessary persistents by doing so. R=tkent@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176217

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix macro usage #

Patch Set 4 : Remove redundant semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M Source/core/editing/UndoStack.h View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/UndoStack.cpp View 3 chunks +10 lines, -6 lines 0 comments Download
M Source/core/page/Page.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look. Just following up on a detail from the editing/ CL.
6 years, 6 months ago (2014-06-16 13:27:17 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-16 13:39:46 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 13:59:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/333313002/60001
6 years, 6 months ago (2014-06-16 14:00:49 UTC) #4
haraken
LGTM
6 years, 6 months ago (2014-06-16 14:53:49 UTC) #5
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 15:41:31 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 15:45:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/333313002/60001
6 years, 6 months ago (2014-06-16 15:46:45 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 16:07:17 UTC) #9
Message was sent while issue was closed. 
Change committed as 176217

Powered by Google App Engine
This is Rietveld 408576698