Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: Source/core/editing/UndoStack.cpp

Issue 333313002: Oilpan: move a page's UndoStack to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove redundant semicolon Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/UndoStack.h ('k') | Source/core/page/Page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/UndoStack.cpp
diff --git a/Source/core/editing/UndoStack.cpp b/Source/core/editing/UndoStack.cpp
index cba100c46f0edb030d226b5c27d5d4b5a9fcd7e6..bc0b0a7b06069d18a76ea93122121c81163bd90e 100644
--- a/Source/core/editing/UndoStack.cpp
+++ b/Source/core/editing/UndoStack.cpp
@@ -45,13 +45,11 @@ UndoStack::UndoStack()
{
}
-UndoStack::~UndoStack()
-{
-}
+DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(UndoStack)
-PassOwnPtr<UndoStack> UndoStack::create()
+PassOwnPtrWillBeRawPtr<UndoStack> UndoStack::create()
{
- return adoptPtr(new UndoStack());
+ return adoptPtrWillBeNoop(new UndoStack());
}
void UndoStack::registerUndoStep(PassRefPtrWillBeRawPtr<UndoStep> step)
@@ -75,7 +73,7 @@ void UndoStack::didUnloadFrame(const LocalFrame& frame)
filterOutUndoSteps(m_redoStack, frame);
}
-void UndoStack::filterOutUndoSteps(WillBePersistentUndoStepStack& stack, const LocalFrame& frame)
+void UndoStack::filterOutUndoSteps(UndoStepStack& stack, const LocalFrame& frame)
{
UndoStepStack newStack;
while (!stack.isEmpty()) {
@@ -122,4 +120,10 @@ void UndoStack::redo()
}
}
+void UndoStack::trace(Visitor* visitor)
+{
+ visitor->trace(m_undoStack);
+ visitor->trace(m_redoStack);
+}
+
} // namesace WebCore
« no previous file with comments | « Source/core/editing/UndoStack.h ('k') | Source/core/page/Page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698