Issue 333053002: Untangle RNG from v8 core

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333053002: Untangle RNG from v8 core (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Untangle RNG from v8 core This will allow for using the RNG from platform files without depending on isolates. BUG=none R=bmeurer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21879

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1

Patch Set 4 : updates #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -19 lines)			Patch
M	src/base/macros.h	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/globals.h	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/isolate-inl.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/utils.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
A +	src/utils/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/utils/random-number-generator.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/random-number-generator.cc	View	1	3 chunks	+4 lines, -9 lines	0 comments	Download
M	test/cctest/test-random-number-generator.cc	View	1 2 3	3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

LGTM with comment. https://codereview.chromium.org/333053002/diff/40001/test/cctest/test-random-number-generator.cc File test/cctest/test-random-number-generator.cc (left): https://codereview.chromium.org/333053002/diff/40001/test/cctest/test-random-number-generator.cc#oldcode77 test/cctest/test-random-number-generator.cc:77: TEST(RandomSeedFlagIsUsed) { Please move this test ...

6 years, 6 months ago (2014-06-16 06:26:24 UTC) #2

jochen (gone - plz use gerrit)

6 years, 6 months ago (2014-06-17 16:27:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r21879 (tree was closed).

Expand Messages | Collapse Messages