Untangle RNG from v8 core

test/cctest/test-random-number-generator.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 54 matching lines @@
 TEST(NextDoubleRange) {
   for (unsigned n = 0; n < ARRAY_SIZE(kRandomSeeds); ++n) {
     RandomNumberGenerator rng(kRandomSeeds[n]);
     for (int k = 0; k < kMaxRuns; ++k) {
       double d = rng.NextDouble();
       CHECK_LE(0.0, d);
       CHECK_LT(d, 1.0);
     }
   }
 }
-
-
-TEST(RandomSeedFlagIsUsed) {

[Benedikt Meurer, 2014/06/16 06:26:24]

Please move this test in test-isolate.cc to test that the new
random_number_generator() function actually uses the FLAG_random_seed.

-  for (unsigned n = 0; n < ARRAY_SIZE(kRandomSeeds); ++n) {
-    FLAG_random_seed = kRandomSeeds[n];
-    RandomNumberGenerator rng1;
-    RandomNumberGenerator rng2(kRandomSeeds[n]);
-    for (int k = 1; k <= kMaxRuns; ++k) {
-      int64_t i1, i2;
-      rng1.NextBytes(&i1, sizeof(i1));
-      rng2.NextBytes(&i2, sizeof(i2));
-      CHECK_EQ(i2, i1);
-      CHECK_EQ(rng2.NextInt(), rng1.NextInt());
-      CHECK_EQ(rng2.NextInt(k), rng1.NextInt(k));
-      CHECK_EQ(rng2.NextDouble(), rng1.NextDouble());
-    }
-  }
-}