Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 33303002: Telemetry: early exit from page runner (Closed)

Created:
7 years, 2 months ago by Luigi Semenzato
Modified:
7 years, 2 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: early exit from page runner Certain Chrome OS tests require that we stop the test and report measurements when certain conditions have been reached. This change allows that. A test that wants to exit prematurely calls self.RequestExit(). The test is exited at the completion of the repeats of the current page. BUG=chromium:309707 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230903

Patch Set 1 #

Patch Set 2 : Telemetry: early exit from page runner. #

Patch Set 3 : Telemetry: early exit from page runner #

Total comments: 1

Patch Set 4 : Telemetry: early exit from page runner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 2 3 6 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Luigi Semenzato
I considered using an exception for this (class EarlyExit(Exception)) but I don't think it's worth ...
7 years, 2 months ago (2013-10-21 18:21:31 UTC) #1
Luigi Semenzato
On 2013/10/21 18:21:31, Luigi Semenzato wrote: > I considered using an exception for this (class ...
7 years, 2 months ago (2013-10-23 16:49:26 UTC) #2
dtu
Looks okay other than one comment. https://chromiumcodereview.appspot.com/33303002/diff/70001/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://chromiumcodereview.appspot.com/33303002/diff/70001/tools/telemetry/telemetry/page/page_test.py#newcode146 tools/telemetry/telemetry/page/page_test.py:146: return False I ...
7 years, 2 months ago (2013-10-23 23:35:24 UTC) #3
Luigi Semenzato
On 2013/10/23 23:35:24, dtu wrote: > Looks okay other than one comment. > > https://chromiumcodereview.appspot.com/33303002/diff/70001/tools/telemetry/telemetry/page/page_test.py ...
7 years, 2 months ago (2013-10-24 21:12:56 UTC) #4
dtu
lgtm
7 years, 2 months ago (2013-10-24 22:12:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/semenzato@chromium.org/33303002/160001
7 years, 2 months ago (2013-10-24 22:43:06 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-25 01:51:15 UTC) #7
Message was sent while issue was closed.
Change committed as 230903

Powered by Google App Engine
This is Rietveld 408576698