tools/telemetry/telemetry/page/page_runner.py - Issue 33303002: Telemetry: early exit from page runner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 33303002: Telemetry: early exit from page runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Telemetry: early exit from page runner Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 45df074bc27015ad67c732780622c7044919daa0..071646493c9e966fccaa9a73431c36360c757530 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -320,7 +320,7 @@ def Run(test, page_set, expectations, finder_options):

finder_options.repeat_options)

state.repeat_state.WillRunPageSet()

- while state.repeat_state.ShouldRepeatPageSet():

+ while state.repeat_state.ShouldRepeatPageSet() and not test.IsExiting():

for page in pages:

state.repeat_state.WillRunPage()

test.WillRunPageRepeats(page, state.tab)

@@ -331,6 +331,8 @@ def Run(test, page_set, expectations, finder_options):

possible_browser, results, state)

state.repeat_state.DidRunPage()

test.DidRunPageRepeats(page, state.tab)

+ if test.IsExiting():

+ break

state.repeat_state.DidRunPageSet()

test.DidRunTest(state.tab, results)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »