Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 333013002: Check alpha-sorting of includes during presubmit. (Closed)

Created:
6 years, 6 months ago by Michael Starzinger
Modified:
6 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Check alpha-sorting of includes during presubmit. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -460 lines) Patch
M samples/lineprocessor.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/process.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/shell.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/accessors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/allocation-tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arguments.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/frames-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm/simulator-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/cpu-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/decoder-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/decoder-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/disasm-arm64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/disasm-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/frames-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/frames-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/instructions-arm64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/instructions-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/instrument-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/lithium-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-gap-resolver-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/regexp-macro-assembler-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/regexp-macro-assembler-arm64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/utils-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M src/ast.h View 2 chunks +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/win32-headers.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bignum.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/cached-powers.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cached-powers.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/conversions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/conversions-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/cpu.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8-posix.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/d8-windows.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/diy-fp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.h View 1 chunk +1 line, -1 line 0 comments Download
M src/field-index.h View 1 chunk +1 line, -1 line 0 comments Download
M src/flags.h View 1 chunk +1 line, -1 line 0 comments Download
M src/flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/frames-inl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/gdb-jit.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gdb-jit.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/hydrogen-load-elimination.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen-store-elimination.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/frames-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter-irregexp.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/default-platform.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.cc View 1 chunk +13 lines, -12 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/lithium-allocator-inl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M src/macro-assembler.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/disasm-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/frames-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/regexp-macro-assembler-mips.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips/simulator-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mksnapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +8 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +8 lines, -8 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform-cygwin.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-freebsd.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M src/platform-qnx.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M src/preparse-data.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/preparse-data.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/preparser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/prettyprinter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/property.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/regexp-macro-assembler-irregexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp-macro-assembler-irregexp-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp-macro-assembler-tracer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp-stack.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/sampler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scanner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/snapshot-common.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-search.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/strtod.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/typing.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/unicode.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.h View 1 chunk +15 lines, -15 lines 0 comments Download
M src/v8.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/v8threads.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/variables.h View 1 chunk +1 line, -1 line 0 comments Download
M src/win32-math.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/frames-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/disasm-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/frames-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/x87/lithium-gap-resolver-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/regexp-macro-assembler-x87.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/regexp-macro-assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/stub-cache-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/zone.h View 1 chunk +1 line, -1 line 0 comments Download
M src/zone-containers.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-circular-queue.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-dictionary.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-hashmap.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-representation.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-time.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unbound-queue.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-utils-arm64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-utils-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 6 months ago (2014-06-13 11:08:45 UTC) #1
rossberg
lgtm
6 years, 6 months ago (2014-06-13 13:22:38 UTC) #2
Michael Starzinger
6 years, 6 months ago (2014-06-20 08:42:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698