Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: pkg/analysis_server/test/domain_analysis_test.dart

Issue 332993006: Implemented analysis.setPrioritySource (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/protocol.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_analysis_test.dart
diff --git a/pkg/analysis_server/test/domain_analysis_test.dart b/pkg/analysis_server/test/domain_analysis_test.dart
index 97e6cb982421fa58fb9565712f6cdcc6ab4d7478..9cd2a288a09945f50c00da44640560401679b4ee 100644
--- a/pkg/analysis_server/test/domain_analysis_test.dart
+++ b/pkg/analysis_server/test/domain_analysis_test.dart
@@ -21,12 +21,13 @@ main() {
groupSep = ' | ';
MockServerChannel serverChannel;
+ MemoryResourceProvider resourceProvider;
AnalysisServer server;
AnalysisDomainHandler handler;
- MemoryResourceProvider resourceProvider = new MemoryResourceProvider();
setUp(() {
serverChannel = new MockServerChannel();
+ resourceProvider = new MemoryResourceProvider();
server = new AnalysisServer(serverChannel, resourceProvider);
server.defaultSdk = new MockSdk();
handler = new AnalysisDomainHandler(server);
@@ -75,14 +76,41 @@ main() {
});
});
- test('setPriorityFiles', () {
- var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
- request.setParameter(
- FILES,
- ['projectA/aa.dart', 'projectB/ba.dart']);
- var response = handler.handleRequest(request);
- // TODO(scheglov) implement
- expect(response, isNull);
+ group('setPriorityFiles', () {
+ test('invalid', () {
+ var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+ request.setParameter(FILES, ['/project/lib.dart']);
+ var response = handler.handleRequest(request);
+ expect(response, isResponseFailure('0'));
+ });
+
+ test('valid', () {
+ resourceProvider.newFolder('/p1');
+ resourceProvider.newFile('/p1/a.dart', 'library a;');
+ resourceProvider.newFolder('/p2');
+ resourceProvider.newFile('/p2/b.dart', 'library b;');
+ resourceProvider.newFile('/p2/c.dart', 'library c;');
+
+ var setRootsRequest = new Request('0', ANALYSIS_SET_ANALYSIS_ROOTS);
+ setRootsRequest.setParameter(INCLUDED, ['/p1', '/p2']);
+ setRootsRequest.setParameter(EXCLUDED, []);
+ var setRootsResponse = handler.handleRequest(setRootsRequest);
+ expect(setRootsResponse, isResponseSuccess('0'));
+
+ setPriorityFiles(List<String> fileList) {
+ var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+ request.setParameter(FILES, fileList);
+ var response = handler.handleRequest(request);
+ expect(response, isResponseSuccess('0'));
+ // TODO(brianwilkerson) Enable the line below after getPriorityFiles
+ // has been implemented.
+ // expect(server.getPriorityFiles(), equals(fileList));
Paul Berry 2014/06/17 18:04:48 I think this needs to be expect(server.getPrior
Brian Wilkerson 2014/06/17 18:43:55 Done
+ }
+
+ setPriorityFiles(['/p1/a.dart', '/p2/b.dart']);
+ setPriorityFiles(['/p2/b.dart', '/p2/c.dart']);
+ setPriorityFiles([]);
+ });
});
test('updateOptions', () {
« no previous file with comments | « pkg/analysis_server/lib/src/protocol.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698