Implemented analysis.setPrioritySource

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/computer/computer_highlights.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/resource.dart';
 import 'package:unittest/unittest.dart';
 
 import 'mocks.dart';
 
 
 main() {
   groupSep = ' | ';
 
   MockServerChannel serverChannel;
+  MemoryResourceProvider resourceProvider;
   AnalysisServer server;
   AnalysisDomainHandler handler;
-  MemoryResourceProvider resourceProvider = new MemoryResourceProvider();
 
   setUp(() {
     serverChannel = new MockServerChannel();
+    resourceProvider = new MemoryResourceProvider();
     server = new AnalysisServer(serverChannel, resourceProvider);
     server.defaultSdk = new MockSdk();
     handler = new AnalysisDomainHandler(server);
   });
 
   group('notification.errors', testNotificationErrors);
   group('notification.highlights', testNotificationHighlights);
   group('notification.navigation', testNotificationNavigation);
   group('updateContent', testUpdateContent);
   group('setSubscriptions', test_setSubscriptions);
@@ skipping 28 matching lines @@
           expect(response, isResponseSuccess('0'));
           // verify that unit is resolved eventually
           return waitForServerOperationsPerformed(server).then((_) {
             var unit = serverRef.test_getResolvedCompilationUnit('/project/bin/test.dart');
             expect(unit, isNotNull);
           });
         });
       });
     });
 
-    test('setPriorityFiles', () {
-      var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
-      request.setParameter(
-          FILES,
-          ['projectA/aa.dart', 'projectB/ba.dart']);
-      var response = handler.handleRequest(request);
-      // TODO(scheglov) implement
-      expect(response, isNull);
+    group('setPriorityFiles', () {
+      test('invalid', () {
+        var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+        request.setParameter(FILES, ['/project/lib.dart']);
+        var response = handler.handleRequest(request);
+        expect(response, isResponseFailure('0'));
+      });
+
+      test('valid', () {
+        resourceProvider.newFolder('/p1');
+        resourceProvider.newFile('/p1/a.dart', 'library a;');
+        resourceProvider.newFolder('/p2');
+        resourceProvider.newFile('/p2/b.dart', 'library b;');
+        resourceProvider.newFile('/p2/c.dart', 'library c;');
+
+        var setRootsRequest = new Request('0', ANALYSIS_SET_ANALYSIS_ROOTS);
+        setRootsRequest.setParameter(INCLUDED, ['/p1', '/p2']);
+        setRootsRequest.setParameter(EXCLUDED, []);
+        var setRootsResponse = handler.handleRequest(setRootsRequest);
+        expect(setRootsResponse, isResponseSuccess('0'));
+
+        setPriorityFiles(List<String> fileList) {
+          var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+          request.setParameter(FILES, fileList);
+          var response = handler.handleRequest(request);
+          expect(response, isResponseSuccess('0'));
+          // TODO(brianwilkerson) Enable the line below after getPriorityFiles
+          // has been implemented.
+          // expect(server.getPriorityFiles(), equals(fileList));

[Paul Berry, 2014/06/17 18:04:48]

I think this needs to be

  expect(server.getPriorityFiles(), unorderedEquals(fileList));

since there's no guarantee of the order of the list returned by
server.getPriorityFiles().

[Brian Wilkerson, 2014/06/17 18:43:55]

Done

+        }
+
+        setPriorityFiles(['/p1/a.dart', '/p2/b.dart']);
+        setPriorityFiles(['/p2/b.dart', '/p2/c.dart']);
+        setPriorityFiles([]);
+      });
     });
 
     test('updateOptions', () {
       var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
       request.setParameter(
           OPTIONS,
           {
             'analyzeAngular' : true,
             'enableDeferredLoading': true,
             'enableEnums': false
@@ skipping 1546 matching lines @@
       // subscribe
       helper.addAnalysisSubscriptionHighlights(helper.testFile);
       // wait, has regions
       return helper.waitForOperationsFinished().then((_) {
         var highlights = helper.getHighlights(helper.testFile);
         expect(highlights, isNot(isEmpty));
       });
     });
   });
 }