Implemented analysis.setPrioritySource

pkg/analysis_server/test/domain_analysis_test.dart

Index: pkg/analysis_server/test/domain_analysis_test.dart
diff --git a/pkg/analysis_server/test/domain_analysis_test.dart b/pkg/analysis_server/test/domain_analysis_test.dart
index 97e6cb982421fa58fb9565712f6cdcc6ab4d7478..e4a9db29c6577e46777e155f422b0626bd326d07 100644
--- a/pkg/analysis_server/test/domain_analysis_test.dart
+++ b/pkg/analysis_server/test/domain_analysis_test.dart
@@ -21,12 +21,13 @@ main() {
   groupSep = ' | ';
 
   MockServerChannel serverChannel;
+  MemoryResourceProvider resourceProvider;
   AnalysisServer server;
   AnalysisDomainHandler handler;
-  MemoryResourceProvider resourceProvider = new MemoryResourceProvider();
 
   setUp(() {
     serverChannel = new MockServerChannel();
+    resourceProvider = new MemoryResourceProvider();
     server = new AnalysisServer(serverChannel, resourceProvider);
     server.defaultSdk = new MockSdk();
     handler = new AnalysisDomainHandler(server);
@@ -75,14 +76,33 @@ main() {
       });
     });
 
-    test('setPriorityFiles', () {
-      var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
-      request.setParameter(
-          FILES,
-          ['projectA/aa.dart', 'projectB/ba.dart']);
-      var response = handler.handleRequest(request);
-      // TODO(scheglov) implement
-      expect(response, isNull);
+    group('setPriorityFiles', () {
+      test('invalid', () {
+        var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+        request.setParameter(
+            FILES,
+            ['/project/lib.dart']);
+        var response = handler.handleRequest(request);
+        expect(response, isResponseFailure('0'));
+      });
+
+      test('valid', () {
+        resourceProvider.newFolder('/project');
+        resourceProvider.newFile('/project/lib.dart', 'library lib;');
+
+        var setRootsRequest = new Request('0', ANALYSIS_SET_ANALYSIS_ROOTS);
+        setRootsRequest.setParameter(INCLUDED, ['/project']);
+        setRootsRequest.setParameter(EXCLUDED, []);
+        var setRootsResponse = handler.handleRequest(setRootsRequest);
+        expect(setRootsResponse, isResponseSuccess('0'));
+
+        var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+        request.setParameter(
+            FILES,
+            ['/project/lib.dart']);
+        var response = handler.handleRequest(request);
+        expect(response, isResponseSuccess('0'));
+      });
     });

[Paul Berry, 2014/06/16 23:43:16]

At a minimum, we should have a test to verify that setPriorityFiles([]) clears
the priority lists for all contexts that previously had non-empty priority
lists.

Depending on the implementation you choose, it might also be good to verify that
setPriorityFiles(list of files from context A) properly clears the priority list
for context B.

[Brian Wilkerson, 2014/06/17 17:46:16]

Agreed.

 
     test('updateOptions', () {