Implemented analysis.setPrioritySource

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/computer/computer_highlights.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/resource.dart';
 import 'package:unittest/unittest.dart';
 
 import 'mocks.dart';
 
 
 main() {
   groupSep = ' | ';
 
   MockServerChannel serverChannel;
+  MemoryResourceProvider resourceProvider;
   AnalysisServer server;
   AnalysisDomainHandler handler;
-  MemoryResourceProvider resourceProvider = new MemoryResourceProvider();
 
   setUp(() {
     serverChannel = new MockServerChannel();
+    resourceProvider = new MemoryResourceProvider();
     server = new AnalysisServer(serverChannel, resourceProvider);
     server.defaultSdk = new MockSdk();
     handler = new AnalysisDomainHandler(server);
   });
 
   group('notification.errors', testNotificationErrors);
   group('notification.highlights', testNotificationHighlights);
   group('notification.navigation', testNotificationNavigation);
   group('updateContent', testUpdateContent);
   group('setSubscriptions', test_setSubscriptions);
@@ skipping 28 matching lines @@
           expect(response, isResponseSuccess('0'));
           // verify that unit is resolved eventually
           return waitForServerOperationsPerformed(server).then((_) {
             var unit = serverRef.test_getResolvedCompilationUnit('/project/bin/test.dart');
             expect(unit, isNotNull);
           });
         });
       });
     });
 
-    test('setPriorityFiles', () {
-      var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
-      request.setParameter(
-          FILES,
-          ['projectA/aa.dart', 'projectB/ba.dart']);
-      var response = handler.handleRequest(request);
-      // TODO(scheglov) implement
-      expect(response, isNull);
+    group('setPriorityFiles', () {
+      test('invalid', () {
+        var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+        request.setParameter(
+            FILES,
+            ['/project/lib.dart']);
+        var response = handler.handleRequest(request);
+        expect(response, isResponseFailure('0'));
+      });
+
+      test('valid', () {
+        resourceProvider.newFolder('/project');
+        resourceProvider.newFile('/project/lib.dart', 'library lib;');
+
+        var setRootsRequest = new Request('0', ANALYSIS_SET_ANALYSIS_ROOTS);
+        setRootsRequest.setParameter(INCLUDED, ['/project']);
+        setRootsRequest.setParameter(EXCLUDED, []);
+        var setRootsResponse = handler.handleRequest(setRootsRequest);
+        expect(setRootsResponse, isResponseSuccess('0'));
+
+        var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
+        request.setParameter(
+            FILES,
+            ['/project/lib.dart']);
+        var response = handler.handleRequest(request);
+        expect(response, isResponseSuccess('0'));
+      });
     });

[Paul Berry, 2014/06/16 23:43:16]

At a minimum, we should have a test to verify that setPriorityFiles([]) clears
the priority lists for all contexts that previously had non-empty priority
lists.

Depending on the implementation you choose, it might also be good to verify that
setPriorityFiles(list of files from context A) properly clears the priority list
for context B.

[Brian Wilkerson, 2014/06/17 17:46:16]

Agreed.

 
     test('updateOptions', () {
       var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
       request.setParameter(
           OPTIONS,
           {
             'analyzeAngular' : true,
             'enableDeferredLoading': true,
             'enableEnums': false
           });
@@ skipping 1545 matching lines @@
       // subscribe
       helper.addAnalysisSubscriptionHighlights(helper.testFile);
       // wait, has regions
       return helper.waitForOperationsFinished().then((_) {
         var highlights = helper.getHighlights(helper.testFile);
         expect(highlights, isNot(isEmpty));
       });
     });
   });
 }