Issue 332973004: Files.app: Fix the flakyness in CreateNewFolderTest and re-enable it

Issue 332973004: Files.app: Fix the flakyness in CreateNewFolderTest and re-enable it (Closed)

Created:
6 years, 6 months ago by yoshiki

Modified:
6 years, 6 months ago

Reviewers:
hirono

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Fix the flakyness in CreateNewFolderTest and re-enable it BUG=377636 TEST=manually test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278665

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed the comments #

Total comments: 2

Patch Set 3 : Addressed the comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -16 lines)			Patch
	M	chrome/browser/chromeos/file_manager/file_manager_browsertest.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
	M	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js	View	1 2	3 chunks	+20 lines, -14 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

hirono

Thank you for fixing it! lgtm with a nit. https://codereview.chromium.org/332973004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js File chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js (right): https://codereview.chromium.org/332973004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js#newcode99 chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js:99: ...

6 years, 6 months ago (2014-06-17 01:27:06 UTC) #2

yoshiki

thanks https://codereview.chromium.org/332973004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js File chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js (right): https://codereview.chromium.org/332973004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js#newcode99 chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js:99: return pending('Selection is not ready (Too many items ...

6 years, 6 months ago (2014-06-17 02:03:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/332973004/20001

6 years, 6 months ago (2014-06-17 02:05:16 UTC) #5

hirono

Sorry, two more. https://codereview.chromium.org/332973004/diff/20001/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js File chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js (right): https://codereview.chromium.org/332973004/diff/20001/chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js#newcode100 chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js:100: elements.length); elements.length -> elements? %j means ...

6 years, 6 months ago (2014-06-17 02:07:46 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/332973004/60001

6 years, 6 months ago (2014-06-20 03:37:07 UTC) #9

Message was sent while issue was closed.

Change committed as 278665

Expand Messages | Collapse Messages