Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 332973004: Files.app: Fix the flakyness in CreateNewFolderTest and re-enable it (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Browser test for basic Chrome OS file manager functionality: 5 // Browser test for basic Chrome OS file manager functionality:
6 // - The file list is updated when a file is added externally to the Downloads 6 // - The file list is updated when a file is added externally to the Downloads
7 // folder. 7 // folder.
8 // - Selecting a file and copy-pasting it with the keyboard copies the file. 8 // - Selecting a file and copy-pasting it with the keyboard copies the file.
9 // - Selecting a file and pressing delete deletes it. 9 // - Selecting a file and pressing delete deletes it.
10 10
(...skipping 797 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 ::testing::Values( 808 ::testing::Values(
809 TestParameter(IN_GUEST_MODE, "audioOpenDownloads"), 809 TestParameter(IN_GUEST_MODE, "audioOpenDownloads"),
810 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDownloads"), 810 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDownloads"),
811 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDrive"), 811 TestParameter(NOT_IN_GUEST_MODE, "audioOpenDrive"),
812 TestParameter(NOT_IN_GUEST_MODE, "audioAutoAdvanceDrive"), 812 TestParameter(NOT_IN_GUEST_MODE, "audioAutoAdvanceDrive"),
813 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatSingleFileDrive"), 813 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatSingleFileDrive"),
814 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatSingleFileDrive"), 814 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatSingleFileDrive"),
815 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatMultipleFileDrive"), 815 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatMultipleFileDrive"),
816 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatMultipleFileDrive"))); 816 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatMultipleFileDrive")));
817 817
818 // Disabled due to frequent failure: http://crbug.com/377636 818 // Slow tests are disabled on debug build. http://crbug.com/327719
819 #if !defined(NDEBUG)
820 #define MAYBE_CreateNewFolder DISABLED_CreateNewFolder
821 #else
822 #define MAYBE_CreateNewFolder CreateNewFolder
823 #endif
819 INSTANTIATE_TEST_CASE_P( 824 INSTANTIATE_TEST_CASE_P(
820 DISABLED_CreateNewFolder, 825 MAYBE_CreateNewFolder,
821 FileManagerBrowserTest, 826 FileManagerBrowserTest,
822 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, 827 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
823 "createNewFolderAfterSelectFile"), 828 "createNewFolderAfterSelectFile"),
824 TestParameter(IN_GUEST_MODE, 829 TestParameter(IN_GUEST_MODE,
825 "createNewFolderDownloads"), 830 "createNewFolderDownloads"),
826 TestParameter(NOT_IN_GUEST_MODE, 831 TestParameter(NOT_IN_GUEST_MODE,
827 "createNewFolderDownloads"), 832 "createNewFolderDownloads"),
828 TestParameter(NOT_IN_GUEST_MODE, 833 TestParameter(NOT_IN_GUEST_MODE,
829 "createNewFolderDrive"))); 834 "createNewFolderDrive")));
830 835
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
1355 } 1360 }
1356 1361
1357 IN_PROC_BROWSER_TEST_F(GalleryBrowserTest, DeleteImageOnDrive) { 1362 IN_PROC_BROWSER_TEST_F(GalleryBrowserTest, DeleteImageOnDrive) {
1358 AddScript("gallery/slide_mode.js"); 1363 AddScript("gallery/slide_mode.js");
1359 set_test_case_name("deleteImageOnDrive"); 1364 set_test_case_name("deleteImageOnDrive");
1360 StartTest(); 1365 StartTest();
1361 } 1366 }
1362 1367
1363 } // namespace 1368 } // namespace
1364 } // namespace file_manager 1369 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698