Fix bug where NVDA wouldn't enter browse mode on page load.

Fix bug where NVDA wouldn't enter browse mode on page load.

This started happening when we started sending events on web pages
before they fully load.

BUG=368549
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276944

[aboxhall, 2014-06-12 22:31:46]

lgtm

https://codereview.chromium.org/332893004/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_manager_win.cc (right):

https://codereview.chromium.org/332893004/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_manager_win.cc:236:
MaybeCallNotifyWinEvent(EVENT_OBJECT_FOCUS, child_id);
Why is this necessary to fix this issue? Superficially it seems like this would
be the opposite of what you wanted, so I'm just curious.

https://codereview.chromium.org/332893004/diff/1/ui/accessibility/ax_tree.cc
File ui/accessibility/ax_tree.cc (right):

https://codereview.chromium.org/332893004/diff/1/ui/accessibility/ax_tree.cc#...
ui/accessibility/ax_tree.cc:172: if (delegate_)
Suggestion: pull these two lines out below the whole if-block.

[dmazzoni, 2014-06-12 23:27:23]

https://codereview.chromium.org/332893004/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_manager_win.cc (right):

https://codereview.chromium.org/332893004/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_manager_win.cc:236:
MaybeCallNotifyWinEvent(EVENT_OBJECT_FOCUS, child_id);
On 2014/06/12 22:31:45, aboxhall wrote:
> Why is this necessary to fix this issue? Superficially it seems like this
would
> be the opposite of what you wanted, so I'm just curious.

When we get a load complete, we know the document is fully loaded - it's
required to send a focus before sending a load complete. The fix up above says
to not send a focus if the document has only begun loading.

https://codereview.chromium.org/332893004/diff/1/ui/accessibility/ax_tree.cc
File ui/accessibility/ax_tree.cc (right):

https://codereview.chromium.org/332893004/diff/1/ui/accessibility/ax_tree.cc#...
ui/accessibility/ax_tree.cc:172: if (delegate_)
On 2014/06/12 22:31:45, aboxhall wrote:
> Suggestion: pull these two lines out below the whole if-block.

Done.

[dmazzoni, 2014-06-12 23:27:27]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-06-12 23:29:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/332893004/20001

[dmazzoni, 2014-06-13 05:24:03]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2014-06-13 05:24:40]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-06-13 05:26:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/332893004/20001

[commit-bot: I haz the power, 2014-06-13 06:46:41]

Change committed as 276944