Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ui/accessibility/ax_tree.cc

Issue 332893004: Fix bug where NVDA wouldn't enter browse mode on page load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simpler_race_fix
Patch Set: Move onNodeChanged below Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/ax_tree.cc
diff --git a/ui/accessibility/ax_tree.cc b/ui/accessibility/ax_tree.cc
index c0ec9ac8c49f6f5c007872a042e374d47c0f85f1..359c8e2fe1d3f62a637a84fe11e0fe7b0e13640a 100644
--- a/ui/accessibility/ax_tree.cc
+++ b/ui/accessibility/ax_tree.cc
@@ -157,8 +157,6 @@ bool AXTree::UpdateNode(
if (node) {
update_state->pending_nodes.erase(node);
node->SetData(src);
- if (delegate_)
- delegate_->OnNodeChanged(node);
} else {
if (src.role != AX_ROLE_ROOT_WEB_AREA) {
error_ = base::StringPrintf(
@@ -171,6 +169,9 @@ bool AXTree::UpdateNode(
node->SetData(src);
}
+ if (delegate_)
+ delegate_->OnNodeChanged(node);
+
// First, delete nodes that used to be children of this node but aren't
// anymore.
if (!DeleteOldChildren(node, src.child_ids)) {
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698