net: Make URLRequestJobFactories mandatory.

net:  Make URLRequestJobFactories mandatory.

The URLRequestJobManager will now crash if there is not one.
This is part of the work aimed at eliminating the JobManager.

BUG=142945
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278192

[mmenke, 2014-06-13 16:48:56]

Figure doing this has a fair chance of a revert, so decided to keep it small and
simple.

[pauljensen, 2014-06-16 11:03:24]

lgtm

[mmenke, 2014-06-16 12:56:36]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-06-16 12:57:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/332833003/1

[commit-bot: I haz the power, 2014-06-16 18:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 18:44:22]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[mmenke, 2014-06-16 19:08:26]

On 2014/06/16 18:44:22, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win_chromium_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

That's a real failure from a CL landed yesterday...  :)

[mmenke, 2014-06-16 20:37:52]

[+bengr]:  Please review components/data_reduction_proxy changes.

This CL makes URLRequestJobFactories mandatory.  Rather than add one to your
tests, I switched to using a TestURLRequestContext, to make future updates
simpler and reduce dependencies.  Needing the HttpUserAgentSettings object is a
bit unfortunate, but I think this is much cleaner, overall.

[bengr, 2014-06-16 20:50:48]

On 2014/06/16 20:37:52, mmenke wrote:
> [+bengr]:  Please review components/data_reduction_proxy changes.
> 
> This CL makes URLRequestJobFactories mandatory.  Rather than add one to your
> tests, I switched to using a TestURLRequestContext, to make future updates
> simpler and reduce dependencies.  Needing the HttpUserAgentSettings object is
a
> bit unfortunate, but I think this is much cleaner, overall.

lgtm. I agree that this is much cleaner.

[mmenke, 2014-06-16 20:57:12]

On 2014/06/16 20:50:48, bengr1 wrote:
> On 2014/06/16 20:37:52, mmenke wrote:
> > [+bengr]:  Please review components/data_reduction_proxy changes.
> > 
> > This CL makes URLRequestJobFactories mandatory.  Rather than add one to your
> > tests, I switched to using a TestURLRequestContext, to make future updates
> > simpler and reduce dependencies.  Needing the HttpUserAgentSettings object
is
> a
> > bit unfortunate, but I think this is much cleaner, overall.
> 
> lgtm. I agree that this is much cleaner.

Thanks!

[mmenke, 2014-06-16 20:57:27]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-06-16 21:00:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/332833003/60001

[mmenke, 2014-06-16 22:24:09]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2014-06-18 18:06:24]

[+palmer]:  Mind reviewing the
chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc changes?

It was using basically an uninitialized URLRequestContext, which seems like a
bad idea.  This CL forces request contexts to have URLREquestJobFactories if you
want to use them for URLRequests.  I've switched the test to using the
TestURLRequestContext, which should be more robust against regressions.

[palmer, 2014-06-18 22:31:45]

LGTM, thanks.

[mmenke, 2014-06-18 22:40:23]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-06-18 22:41:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/332833003/80001

[commit-bot: I haz the power, 2014-06-18 23:46:13]

Change committed as 278192