net/url_request/url_request.cc - Issue 332833003: net: Make URLRequestJobFactories mandatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request.cc

Issue 332833003: net: Make URLRequestJobFactories mandatory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Switch some tests to TestURLRequestContext Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request.cc

diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc

index d98ad5d91bef3f6aa0e7eb672a229e9f73cd7c67..7495b7e5d8dfe64ea6778ae77d7760962388e4dc 100644

--- a/net/url_request/url_request.cc

+++ b/net/url_request/url_request.cc

@@ -614,6 +614,9 @@ void URLRequest::set_delegate(Delegate* delegate) {

}

void URLRequest::Start() {

+ // Some values can be NULL, but the job factory must not be.

+ DCHECK(context_->job_factory());

DCHECK_EQ(network_delegate_, context_->network_delegate());

// Anything that sets |blocked_by_| before start should have cleaned up after

// itself.