Enable compiling with automatically-downloaded VS toolchain on Windows bots

Enable compiling with automatically-downloaded VS toolchain on Windows bots

Requires that the bots have CHROME_HEADLESS=1 and CHROME_PATH set.

BUG=skia:2216
R=epoger@google.com

Committed: https://skia.googlesource.com/skia/+/9118413

[borenet, 2014-06-12 20:14:45]

I don't expect this to work until all bots have a checkout of Chrome and the
CHROME_PATH variable set.

[epoger, 2014-06-12 20:43:10]

https://codereview.chromium.org/332833002/diff/1/gyp_skia
File gyp_skia (right):

https://codereview.chromium.org/332833002/diff/1/gyp_skia#newcode99
gyp_skia:99: os.chdir(chrome_path)
do we need to chdir back out of here afterwards?

https://codereview.chromium.org/332833002/diff/1/make.bat
File make.bat (right):

https://codereview.chromium.org/332833002/diff/1/make.bat#newcode7
make.bat:7: rem Launches make.py on Windows
What happens if human developers run this?  Will it still work for them?

[borenet, 2014-06-12 20:50:58]

Uploaded patch set 2.

https://codereview.chromium.org/332833002/diff/1/gyp_skia
File gyp_skia (right):

https://codereview.chromium.org/332833002/diff/1/gyp_skia#newcode99
gyp_skia:99: os.chdir(chrome_path)
On 2014/06/12 20:43:09, epoger wrote:
> do we need to chdir back out of here afterwards?

No, since the first line after this block does a chdir to an absolute path.

https://codereview.chromium.org/332833002/diff/1/make.bat
File make.bat (right):

https://codereview.chromium.org/332833002/diff/1/make.bat#newcode7
make.bat:7: rem Launches make.py on Windows
On 2014/06/12 20:43:10, epoger wrote:
> What happens if human developers run this?  Will it still work for them?

I backpedaled a little in patch set 2.

[epoger, 2014-06-12 20:52:22]

lgtm

[borenet, 2014-06-16 13:52:39]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-06-16 13:52:47]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/borenet@google.com/332833002/20001

[commit-bot: I haz the power, 2014-06-16 13:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 13:52:49]

Failed to apply patch for make.bat:
While running git apply --index -p1;
  error: patch failed: make.bat:7
  error: make.bat: patch does not apply

Patch:       make.bat
Index: make.bat
diff --git a/make.bat b/make.bat
index
a9961074e347cdcc4abb42cfeb0559b234ee7cc0..2b6a629ff377d6554faa277df924e328135e7866
100644
--- a/make.bat
+++ b/make.bat
@@ -7,6 +7,9 @@
 rem Launches make.py on Windows, after setting Visual Studio environment
variables.
 rem See http://code.google.com/p/skia/wiki/GettingStartedOnWindows
 
+rem Skip environment setup on bots.
+if "%CHROME_HEADLESS%"=="1" goto run_python
+
 if "%DevEnvDir%"=="" goto setup_env_vars
 
 :run_python

[borenet, 2014-06-16 13:55:09]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-06-16 13:55:47]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/borenet@google.com/332833002/40001

[commit-bot: I haz the power, 2014-06-16 13:56:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 13:56:05]

Failed to apply patch for make.bat:
While running git apply --index -p1;
  error: patch failed: make.bat:7
  error: make.bat: patch does not apply

Patch:       make.bat
Index: make.bat
diff --git a/make.bat b/make.bat
index
a9961074e347cdcc4abb42cfeb0559b234ee7cc0..2b6a629ff377d6554faa277df924e328135e7866
100644
--- a/make.bat
+++ b/make.bat
@@ -7,6 +7,9 @@
 rem Launches make.py on Windows, after setting Visual Studio environment
variables.
 rem See http://code.google.com/p/skia/wiki/GettingStartedOnWindows
 
+rem Skip environment setup on bots.
+if "%CHROME_HEADLESS%"=="1" goto run_python
+
 if "%DevEnvDir%"=="" goto setup_env_vars
 
 :run_python

[borenet, 2014-06-16 14:00:39]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-06-16 14:00:46]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/borenet@google.com/332833002/60001

[commit-bot: I haz the power, 2014-06-16 14:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 14:00:49]

Failed to apply patch for make.bat:
While running git apply --index -p1;
  error: patch failed: make.bat:7
  error: make.bat: patch does not apply

Patch:       make.bat
Index: make.bat
diff --git a/make.bat b/make.bat
index
a9961074e347cdcc4abb42cfeb0559b234ee7cc0..2b6a629ff377d6554faa277df924e328135e7866
100644
--- a/make.bat
+++ b/make.bat
@@ -7,6 +7,9 @@
 rem Launches make.py on Windows, after setting Visual Studio environment
variables.
 rem See http://code.google.com/p/skia/wiki/GettingStartedOnWindows
 
+rem Skip environment setup on bots.
+if "%CHROME_HEADLESS%"=="1" goto run_python
+
 if "%DevEnvDir%"=="" goto setup_env_vars
 
 :run_python

[borenet, 2014-06-16 14:02:47]

Committed patchset #4 manually as r9118413 (presubmit successful).